This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Add deprecation guide for ds.deprecated-initializers #2780 #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
suggested changes
Jan 8, 2017
| ``` | ||
|
|
||
| After: | ||
| ```javascript |
There was a problem hiding this comment.
Empty line before code block please!
| The Ember Data initializers `data-adapter`, `injectStore`, `transforms`, and `store` are no longer used, so they are being removed. Apps that depend on these for the ordering of their own custom initializers can substitute `ember-data` instead, without any change in functionality. | ||
|
|
||
| Before: | ||
| ```javascript |
There was a problem hiding this comment.
Empty line before code block please!
| ###### until: 3.0.0 | ||
| ###### id: ds.deprecated-initializers | ||
|
|
||
| The Ember Data initializers `data-adapter`, `injectStore`, `transforms`, and `store` are no longer used, so they are being removed. Apps that depend on these for the ordering of their own custom initializers can substitute `ember-data` instead, without any change in functionality. |
There was a problem hiding this comment.
Can you replace "Apps" with "Applications" and add a newline after the "removed." full stop?
Like so:
… removed.
Applications that …
There was a problem hiding this comment.
Should there always be newlines at the end of sentences?
locks
approved these changes
Jan 8, 2017
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2780
@locks