Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

new responsive styles and markup for Showcase component (ember-users and sponsors) #2583

Merged
merged 1 commit into from
May 14, 2016

Conversation

steveszc
Copy link
Contributor

Helping at the Denver Ember Meet-up Open Source Night.

I updated the emberjs.com/ember-users page to add responsive styling, this page utilizes the showcase component for displaying user logos. The update involved adding some new css rules, and I updated the markup for the showcase component from a table-based layout to a unordered list, which is a more appropriate and semantic markup structure for this content.

The Showcase component is also used on the emberjs.com/sponsors page (which was already responsive) so I updated the markup structure there too, and made a few necessary CSS changes related to the sponsors page. I ended up moving some showcase-related styles from the sponsors scss partial to the main site scss partial so that all the showcase styles are co-located.

The Showcase component's visual layout is by-and-large identical with these changes. The new responsive layout shows the logos in a single column on small screens, in rows of two on medium screens, and rows of three of larger screens. There are a couple very minor differences in some padding and text sizes on the Sponsors Showcase due to some inherited styles from the ul/li elements, probably not worth the trouble of fixing.

@acorncom
Copy link
Contributor

@steveszc Would you be able to send over a few screenshots showing how things look?

@steveszc
Copy link
Contributor Author

@acorncom Here are screens from the /ember-users page

/ember-users (large screen)
users-large-full

/ember-users (medium screen)
users-medium-full

/ember-users (small screen)
users-small-full

@steveszc
Copy link
Contributor Author

@acorncom And here are screens from the /sponsors page

/sponsors (large screen)
sponsors-large

/sponsors (medium screen)
sponsors-medium

/sponsors (small screen)
sponsors-small

@locks
Copy link
Contributor

locks commented May 14, 2016

Thanks for your contribution!

@homu r+

@locks
Copy link
Contributor

locks commented May 14, 2016

Oops, no homu here yet xD

@locks locks merged commit cf1c212 into emberjs:master May 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants