This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
new responsive styles and markup for Showcase component (ember-users and sponsors) #2583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helping at the Denver Ember Meet-up Open Source Night.
I updated the emberjs.com/ember-users page to add responsive styling, this page utilizes the showcase component for displaying user logos. The update involved adding some new css rules, and I updated the markup for the showcase component from a table-based layout to a unordered list, which is a more appropriate and semantic markup structure for this content.
The Showcase component is also used on the emberjs.com/sponsors page (which was already responsive) so I updated the markup structure there too, and made a few necessary CSS changes related to the sponsors page. I ended up moving some showcase-related styles from the sponsors scss partial to the main site scss partial so that all the showcase styles are co-located.
The Showcase component's visual layout is by-and-large identical with these changes. The new responsive layout shows the logos in a single column on small screens, in rows of two on medium screens, and rows of three of larger screens. There are a couple very minor differences in some padding and text sizes on the Sponsors Showcase due to some inherited styles from the ul/li elements, probably not worth the trouble of fixing.