Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

[WIP] Refactor HTML/CSS through the Community page #2523

Closed
wants to merge 5 commits into from

Conversation

zeppelin
Copy link
Contributor

This PR aims to add responsive layout to the website, but a lot of refactoring is planned before in order to do that.

@acorncom
Copy link
Contributor

@zeppelin Would suggest we do this in small increments (and multiple PRs) instead of one giant PR. Due to how visible changes here could be, we're all a bit leery of major PRs 😄

I'm at the contributors workshop if you want to discuss in more detail

@zeppelin
Copy link
Contributor Author

Sure, I'll update the PR's title & branch name to reflect the actual (smaller) changes. The current title is only meant to communicate the end goal to get feedback early.

@zeppelin zeppelin force-pushed the responsive-layout branch from a3f3276 to 1ba8d2a Compare March 28, 2016 23:28
@toovy
Copy link

toovy commented Apr 1, 2016

@zeppelin In parallel I've also started with responsive adaptations. I've started with the about page, introduced bourbon/neat as grid, mostly just reworked CSS and some JS/templates to get the examples running. I did not really scratch the HTML, but the refactor you are doing is probably also important. For the about page the only thing left is the Tomster Mail example. It heavily relies on tables...

If we join forces somehow I think we could get it done faster. How shall we proceed? Can I create a PR to your fork?

@toovy toovy mentioned this pull request Apr 1, 2016
18 tasks
@import "compass";
@import "mixins/hidpi";

@mixin community-content($selector) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a mixin?

@zeppelin
Copy link
Contributor Author

@toovy sounds awesome, definitely interested in joining forces! I'm back home now from EmberConf, will check out your branch & concept, as soon as I catch up with the rest of my things.

@zeppelin zeppelin changed the title [WIP] Responsive layout [WIP] Refactor HTML/CSS through the Community page Apr 12, 2016
@toovy
Copy link

toovy commented Apr 12, 2016

@zeppelin nice, I'll see if I can push my results today!

@locks
Copy link
Contributor

locks commented Apr 24, 2016

@zeppelin @toovy @ryanlabouve any updates?

@toovy
Copy link

toovy commented Apr 25, 2016

@locks @zeppelin reviews my stuff today (or so) with the aim to create a development strategy afterwards.

@locks
Copy link
Contributor

locks commented May 18, 2016

@toovy @zeppelin how did the review go?

@toovy
Copy link

toovy commented May 18, 2016

@locks no feedback yet. Don't know how to proceed.

@zeppelin
Copy link
Contributor Author

zeppelin commented May 20, 2016

@toovy @locks I'm alive! Had no time whatsoever to work on OSS - so I did quit the company I was working for :) I'm reviewing it right now. Might take some though...

@toovy
Copy link

toovy commented May 23, 2016

@zeppelin wow, cool stuff. I'm not available for the next two weeks so pls feel free to merge/rewrite my PR.

@locks
Copy link
Contributor

locks commented Jul 1, 2016

I am closing this PR due to lack of movement. Please keep the changes smaller next time, it makes it easier to review and merge. And we don't mind multiple PRs :]
Thanks for the work so far, I hope you contribute them back again in the future.

@locks locks closed this Jul 1, 2016
@zeppelin
Copy link
Contributor Author

zeppelin commented Jul 1, 2016

@locks you're quite right about closing it. The commits are there and ready to be cherry-picked whenever I'm able to continue working on it. However, I'm intend to bring the website & the guides closer together, this should make the responsive movement easier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants