-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[WIP] Refactor HTML/CSS through the Community page #2523
Conversation
@zeppelin Would suggest we do this in small increments (and multiple PRs) instead of one giant PR. Due to how visible changes here could be, we're all a bit leery of major PRs 😄 I'm at the contributors workshop if you want to discuss in more detail |
Sure, I'll update the PR's title & branch name to reflect the actual (smaller) changes. The current title is only meant to communicate the end goal to get feedback early. |
a3f3276
to
1ba8d2a
Compare
@zeppelin In parallel I've also started with responsive adaptations. I've started with the about page, introduced bourbon/neat as grid, mostly just reworked CSS and some JS/templates to get the examples running. I did not really scratch the HTML, but the refactor you are doing is probably also important. For the about page the only thing left is the Tomster Mail example. It heavily relies on tables... If we join forces somehow I think we could get it done faster. How shall we proceed? Can I create a PR to your fork? |
@import "compass"; | ||
@import "mixins/hidpi"; | ||
|
||
@mixin community-content($selector) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use a mixin?
@toovy sounds awesome, definitely interested in joining forces! I'm back home now from EmberConf, will check out your branch & concept, as soon as I catch up with the rest of my things. |
@zeppelin nice, I'll see if I can push my results today! |
@zeppelin @toovy @ryanlabouve any updates? |
@locks no feedback yet. Don't know how to proceed. |
@zeppelin wow, cool stuff. I'm not available for the next two weeks so pls feel free to merge/rewrite my PR. |
I am closing this PR due to lack of movement. Please keep the changes smaller next time, it makes it easier to review and merge. And we don't mind multiple PRs :] |
@locks you're quite right about closing it. The commits are there and ready to be cherry-picked whenever I'm able to continue working on it. However, I'm intend to bring the website & the guides closer together, this should make the responsive movement easier. |
This PR aims to add responsive layout to the website, but a lot of refactoring is planned before in order to do that.