-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Port Responsive Header and Footer from Guides #2477
Conversation
In docs discussion, we talked about:
|
Updating this PR to incorporate recent changes for header on narrow screens: emberjs/guides#1306 |
* add flag for responsive
Adding a `.responsive` and `.not-responsive` class to body based on frontmatter `responsive: true`. Pages are all not responsive by default. This will allow a more gradual migration for the website to support responsive. The responsive viewport is meta tag is also toggled on and off by the same responsive frontmatter variable per page.
Finished the changes to allow pages to opt-in to the responsive footer and header (with the help of @mixonic). Attaching a series of GIFs to demonstrate this behavior on responsive vs. non-responsive pages. Final pixel-to-pixel comparison (even showing off the stated temporary horizontal spacing difference due to different grids on guides and website): |
@ryanlabouve so very very close. The header between guides and the website when on mobile is a little jank still. A far worse gif than yours: The header changes height, and the emberjs logo is centered only on the website version. I actually suggest the guides repo change to center the logo. |
@mixonic I've made some final adjustments that should resolve this. Since this is such a high traffic area of the website, I've made another round of comparison GIFs for to show the responsive and non-responsive version of the header compared to guides from the latest commit. Wide screens (which, as expected due to different grids, has some horizontal shifting): |
Port Responsive Header and Footer from Guides
I'm working on the 2016 Ember Community Survey landing page. It would be nice to have a responsive header since likely many of the folks viewing the survey on their mobile devices.
I did a quick port of the header from https://guides.emberjs.com/v2.3.0/ across the whole website.
Would something like this be welcomed / helpful?
A few notes:
Screenshot:
