Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: ember-data | state-machine-update #737

Closed

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Apr 24, 2021

Full Text: Rendered
Implementation PR: emberjs/data#7475

@runspired runspired added the T-ember-data RFCs that impact the ember-data library label Apr 24, 2021
@runspired
Copy link
Contributor Author

After discussion there is some disagreement over whether this is useful given once the RECORD_DATA_STATE and RECORD_DATA_ERRORS flags are activated we intend to deprecate the state-machine entirely. Adding new sub-states only to deprecate all of them soon thereafter feels somewhat awkward.

However, the boolean flag changes this proposes are states which need to be possible in the new world as well. We are going to investigate making the boolean flags work for the states proposed here without causing any changes to stateName, and ensure that they work in both worlds. We will revisit this with a mind to update the RECORD_DATA_STATE rfc if that cannot be achieved.

@runspired
Copy link
Contributor Author

Closing in favor of removal of the state machine entirely. The state machine has been refactored away from public APIs in emberjs/data#7258 and we will RFC a deprecation for currentState.stateName. The flags will remain public API on model and flag states can be made to correctly reflect truthiness in deletion / empty-state without this RFC.

@runspired runspired closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-ember-data RFCs that impact the ember-data library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant