Add descriptor()
#442
Closed
Add descriptor()
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
20 tasks
MelSumner
reviewed
Feb 27, 2019
| All examples including tracked properties in the guides which have a classic | ||
| class equivalent will use `descriptor` instead of native getters, demonstrating | ||
| how it works by example. | ||
|
|
There was a problem hiding this comment.
This is already in the guides, yes?
There was a problem hiding this comment.
It is in the Octane branch, yes. We can remove it if this RFC is not accepted though.
|
We were able to make actual native getters work in EmberObject.extend({
get foo() {}
});So this feature isn't necessary anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered