-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for this.attrs #1016
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,61 @@ | ||||||
--- | ||||||
stage: accepted | ||||||
start-date: 2020-12-22T00:00:00.000Z | ||||||
release-date: 2021-03-22T00:00:00.000Z | ||||||
release-versions: | ||||||
ember-source: v3.26.0 | ||||||
|
||||||
teams: | ||||||
- framework | ||||||
prs: | ||||||
accepted: https://github.com/emberjs/rfcs/pull/1016 | ||||||
project-link: | ||||||
--- | ||||||
|
||||||
# Deprecate using `{{attrs}}` and {{this.attrs}} in templates | ||||||
|
||||||
## Summary | ||||||
|
||||||
[RFC #690](https://github.com/emberjs/rfcs/pull/690) had some unfortunate timing where `{{attrs}}` was widely used, but before usage of `{{this.x}}` became widely common. As such, the deprecation messaging [implemented here](https://github.com/emberjs/ember.js/blob/0822efd9c0554f11d01232585596ac70c14a4306/packages/ember-template-compiler/lib/plugins/assert-against-attrs.ts#L58) only messaged in the case of `{{attrs}}`, rather than both `{{attrs}}` and `{{this.attrs}}`. | ||||||
|
||||||
|
||||||
The RFC had intended, and even describes in its transition path to move away from `{{this.attrs}}`. [The code for the build time assertion](https://github.com/emberjs/ember.js/blob/0822efd9c0554f11d01232585596ac70c14a4306/packages/ember-template-compiler/lib/plugins/assert-against-attrs.ts#L84) even tried to handle the `{{this.attrs}}` case. | ||||||
|
||||||
|
||||||
```hbs | ||||||
{{attrs.foo}} and {{this.attrs.foo}} | ||||||
|
||||||
{{! is equivalent to }} | ||||||
{{@foo}} and {{@foo}} | ||||||
``` | ||||||
|
||||||
It was a legacy API that existed prior to named arguments being introduced in | ||||||
Ember, and has continued to be supported via a template transform for some time. | ||||||
|
||||||
This RFC proposes that we add a deprecation warning to the build-time assertion that forbids `{{attrs}}`, it will also forbid `{{this.attrs}}`. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
## Motivation | ||||||
|
||||||
The `{{attrs}}` / `{{this.attrs}}` syntax was from a previous iteration of the concepts that | ||||||
eventually became named argument syntax. Now that named arguments exist in the | ||||||
framework, and are considered the best practice, there is no reason to continue | ||||||
supporting this syntax. | ||||||
|
||||||
## Transition Path | ||||||
|
||||||
Users who currently rely on referencing `{{attrs}}` or `{{this.attrs}}` can convert their references | ||||||
to named arguments. | ||||||
|
||||||
## How We Teach This | ||||||
|
||||||
### Deprecation Guide | ||||||
|
||||||
The deprecation guide from [3.26.0](https://deprecations.emberjs.com/v3.x#toc_attrs-arg-access) is already sufficient. | ||||||
|
||||||
## Alternatives | ||||||
|
||||||
pre-v6 deprecation. | ||||||
|
||||||
## Drawbacks | ||||||
|
||||||
- None |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is less confusing