Skip to content

Commit

Permalink
Merge branch 'gj/deprecate-partials' of github.com:GavinJoyce/rfcs in…
Browse files Browse the repository at this point in the history
…to gj/deprecate-partials
  • Loading branch information
GavinJoyce committed Mar 16, 2019
2 parents cbdd2d8 + e8ebcfe commit c0be65f
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions text/0000-template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- Start Date: 2019-02-17
- Relevant Teams: Ember.js, Learning
- RFC PR: https://github.com/emberjs/rfcs/pull/TODO
- RFC PR: https://github.com/emberjs/rfcs/pull/449
- Tracking: (leave this empty)

# Deprecate `{{partial}}`
Expand All @@ -18,7 +18,7 @@ Partials have a number of downsides when compared with components:

Partials should have no place in modern Ember applications, components should always be preferred.

Once removed, Ember's API will become smaller and more consistetnt.
Once removed, Ember's API will become smaller and more consistent.

## Detailed design

Expand Down Expand Up @@ -85,7 +85,9 @@ A codemod, while not necessary for this RFC to land, would greatly simplify the

We'll mentiton the deprecation in an Ember point release blog post.

The deprecation message will contain a link to clear guidelines on how to migrate from a `{{partial}}` to a component.
The deprecation message will contain a link to clear guidelines on how to migrate from a `{{partial}}` to a component. See the section above beginning with "The use of `{{partial}}` has been deprecated..." for the content.

There are no changes to make to the Ember.js guides, since mentions of `{{partial}}` were removed in 2.x guides.

## Drawbacks

Expand Down

0 comments on commit c0be65f

Please sign in to comment.