Fix for Issue #501 Update examples in "Testing Components" guide to use Integration Tests

[toddjordan]

See issue #501

I redid the same examples using integration tests. I also got the examples working in a sample app to verify them. I also included some other newer practices such as pods and some more es6 mechanisms.

There's enough changes here where you might want to look at the split diff

[toddjordan]

Since this was already commented I went ahead and deleted. I can work on bringing it back if we feel its important. Now that we use integration tests I don't really think there's going to be much different about nested components that cause this section. you'd just declare the components in the render template and assert the DOM

[michaelrkn]

Thanks a bunch for picking this up, @toddjordan!

[michaelrkn]

We're not going to encourage people to use the pod directory structure until it's format has settled down. Can you re-do the examples with the "regular" structure for now?

[toddjordan]

Absolutely. I'll go back and update

[michaelrkn]

@locks can you review as well?

[toddjordan]

@michaelrkn I also have a new section on stubbing services using the example in my blog post here:

http://presentationtier.com/stubbing-services-in-emberjs-integration-tests/

I'd like to add a new section to "Testing Components" based on the example, with language consistent with the others. Should I add the section to this PR?

Here a PR within my guides fork with the added section: https://github.com/toddjordan/guides/pull/2/files

[michaelrkn]

@toddjordan I'd say open a separate PR for that, after this is merged. It's easier and faster to review things individually.

@locks Can you review this so that @toddjordan can move forward?

Thanks!

[toddjordan]

will do, thx

[mixonic]

@toddjordan I'm concerned with this.container.lookup in your test. I don't believe the container is considered public API. The rest seems reasonable, and there are ways to set values after lookup without using the container.

• Stash the instance during init of the stub and set against that
• Register a singleton object instead of a class for the service- may require some mucking about with the options for registering.

Nice writeup though!

[toddjordan]

Thx for the tip. I'll look into modifying the example to a lookup alternative.

[mixonic]

@toddjordan Also note that Ember 2.1 has tweaked some of these APIs. You can find links to data about those changes in this issue.

[toddjordan]

I noticed the PR where you can do the same thing in a test with this.registry.register(...) as you can with this.container.register(...) If that's the preferred way I can update that.

[michaelrkn]

@toddjordan is this ready to merge? I don't see this.container.lookup, this.registry.register, or this.container.register in there, so I want to make sure it's in the right place, since that business is a bit above my head :)

[toddjordan]

@michaelrkn yeah that discussion was around another PR for the new section on stubbing services for component integration tests. I haven't PR'd that to guides yet. This PR is just converting this existing examples, so yes, its good to go when you guys are ok with it.