This repository has been archived by the owner on May 26, 2019. It is now read-only.
Update documentation to include route-serializer info #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Awesome, thank you @trentmwillis. We will likely hold this PR and merge closer to the release version of the feature, but I defer to the @emberjs/guides-managers on that... |
|
I confirm, it will get merged when we do the review period freeze so we can get updates to the current content in as much as possible. |
| }); | ||
| ``` | ||
|
|
||
| If no `serialize` function is defined, then a straight property lookup on the model will be used for each segment instead. |
There was a problem hiding this comment.
Can you give an example? Or maybe inverse it, first explain how the default works, and then explain how you can customize. I believe you can check the model() hook documentation for a similar flow.
There was a problem hiding this comment.
Makes sense. Will update.
trentmwillis
force-pushed
the
route-serializers
branch
from
b175bbc to
4cedebb
Compare
|
@locks updated. Let me know what you think. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in emberjs/ember.js#13016 and discussed in the RFC: Route Serializers. Let me know if anything else is needed as I haven't contributed to the guides before.