-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for data-tag-name attribute on handlebars script tag #299
Conversation
Is this something we can write tests for? I can't recall if we have tests for |
test("scripts with data-template-name should be added to Ember.TEMPLATES", function() { | ||
}); | ||
|
||
test("templates with data-tag-name should create templates with specific tag name", function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I test a custom HTML page with QUnit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not expecting that you'd be able to make a full integration level test, just that you may be able to test some of the pieces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, kind of difficult with how the Ember.Handlebars.bootstrap looks like https://github.com/emberjs/ember.js/blob/master/packages/ember-handlebars/lib/loader.js
Do you have any suggestions?
OK, I've added some tests for the |
add support for data-tag-name attribute on handlebars script tag
…rn/ember-qunit-4.4.1
Inspired by question http://stackoverflow.com/questions/8629287/how-do-you-specify-the-tag-name-for-sproutcore-emberjs-inline-script-templates I've added support for
data-tag-name
which defines thetagName
on the view created for a handlebars template.Example:
which outputs