Update to TS v4.9 #20285
Merged
Update to TS v4.9 #20285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
force-pushed
the
add-ts-4.9-explicitly
branch
from
971e443 to
e00d427
Compare
This lets us take advantage of much smarter `in`-based type narrowing and the new `satisfies` operator internally. We'll need to make a decision about what versions to support when we actually "stabilize" the types: not merely publishing them, but opting consumers into them by default. However, it's likely that 4.9 and 5.0 will be reasonable targets at that point, and even if not the particular 4.9 features we might rely on are "runtime" TS features, so we should be able to add a CI check for 4.8 if we want to add support for it in the test matrix.
chriskrycho
force-pushed
the
add-ts-4.9-explicitly
branch
from
e00d427 to
1c779a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us take advantage of much smarter
in-based type narrowing and the newsatisfiesoperator internally. We'll need to make a decision about what versions to support when we actually "stabilize" the types: not merely publishing them, but opting consumers into them by default. However, it's likely that 4.9 and 5.0 will be reasonable targets at that point, and even if not the particular 4.9 features we might rely on are "runtime" TS features, so we should be able to add a CI check for 4.8 if we want to add support for it in the test matrix.