Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove EMBER_CACHE_API feature flag #19204

Merged
merged 2 commits into from
Oct 16, 2020
Merged

[CLEANUP] Remove EMBER_CACHE_API feature flag #19204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28684dc
[CLEANUP] Remove EMBER_CACHE_API feature flag
andreisebastianc Oct 16, 2020
019ae7b
[CLEANUP] Remove EMBER_CACHE_API feature flag from documentation
andreisebastianc Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/@ember/-internals/metal/lib/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export { createCache, getValue, isConst } from '@glimmer/validator';
updated.

@module @glimmer/tracking/primitives/cache
@category EMBER_CACHE_API
@public
*/

Expand Down Expand Up @@ -49,7 +48,6 @@ export { createCache, getValue, isConst } from '@glimmer/validator';
```

@method createCache
@category EMBER_CACHE_API
@static
@for @glimmer/tracking/primitives/cache
@public
Expand All @@ -72,7 +70,6 @@ export { createCache, getValue, isConst } from '@glimmer/validator';
```

@method getValue
@category EMBER_CACHE_API
@static
@for @glimmer/tracking/primitives/cache
@public
Expand Down Expand Up @@ -120,7 +117,6 @@ export { createCache, getValue, isConst } from '@glimmer/validator';
accident.

@method isConst
@category EMBER_CACHE_API
@static
@for @glimmer/tracking/primitives/cache
@public
Expand Down
2 changes: 0 additions & 2 deletions packages/@ember/canary-features/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export const DEFAULT_FEATURES = {
EMBER_NAMED_BLOCKS: null,
EMBER_GLIMMER_SET_COMPONENT_TEMPLATE: true,
EMBER_ROUTING_MODEL_ARG: true,
EMBER_CACHE_API: true,
EMBER_DESTROYABLES: true,
EMBER_GLIMMER_HELPER_MANAGER: true,
EMBER_GLIMMER_INVOKE_HELPER: true,
Expand Down Expand Up @@ -78,7 +77,6 @@ export const EMBER_GLIMMER_SET_COMPONENT_TEMPLATE = featureValue(
FEATURES.EMBER_GLIMMER_SET_COMPONENT_TEMPLATE
);
export const EMBER_ROUTING_MODEL_ARG = featureValue(FEATURES.EMBER_ROUTING_MODEL_ARG);
export const EMBER_CACHE_API = featureValue(FEATURES.EMBER_CACHE_API);
export const EMBER_DESTROYABLES = featureValue(FEATURES.EMBER_DESTROYABLES);
export const EMBER_GLIMMER_HELPER_MANAGER = featureValue(FEATURES.EMBER_GLIMMER_HELPER_MANAGER);
export const EMBER_GLIMMER_INVOKE_HELPER = featureValue(FEATURES.EMBER_GLIMMER_INVOKE_HELPER);
Expand Down
9 changes: 3 additions & 6 deletions packages/ember/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
EMBER_GLIMMER_HELPER_MANAGER,
EMBER_GLIMMER_INVOKE_HELPER,
EMBER_GLIMMER_SET_COMPONENT_TEMPLATE,
EMBER_CACHE_API,
EMBER_DESTROYABLES,
EMBER_MODERNIZED_BUILT_IN_COMPONENTS,
} from '@ember/canary-features';
Expand Down Expand Up @@ -351,11 +350,9 @@ Ember.observer = metal.observer;
Ember.mixin = metal.mixin;
Ember.Mixin = metal.Mixin;

if (EMBER_CACHE_API) {
Ember._createCache = metal.createCache;
Ember._cacheGetValue = metal.getValue;
Ember._cacheIsConst = metal.isConst;
}
Ember._createCache = metal.createCache;
Ember._cacheGetValue = metal.getValue;
Ember._cacheIsConst = metal.isConst;

if (EMBER_DESTROYABLES) {
Ember._registerDestructor = registerDestructor;
Expand Down