[BUGFIX beta] Avoid breaking {{-in-element}} usage #18727
Conversation
packages/ember-template-compiler/lib/plugins/transform-in-element.ts
Outdated
Show resolved
Hide resolved
The intimate `{{#-in-element}}` API previously defaults to appending
to the remote element without clearing. With the VM upgrade, the
default has changed to clearing the remote element as specified by
the RFC. Since we are not ready to promote the public API yet, we
should preserve the exisiting behavior and let addon authors migrate
to the new public API directly when it is ready.
chancancode
force-pushed
the
fix-in-element
branch
from
1d95b4d to
da6c5fa
Compare
|
Just wanted to clarify, what is the relationship to #18696? |
|
@rwjblue unrelated; I have a different fix for that on the VM side. |
|
This makes sense, thanks @chancancode for fixing that! FWIW, I was not sure if it was intentional to land the semantic changes here even when not making this public yet, so I tried to fix my polyfill for that change (ember-polyfills/ember-in-element-polyfill#37), but this seems unnecessary now. Which is good! On that matter: what is the reason for not making |
The intimate
{{#-in-element}}API previously defaults to appending to the remote element without clearing. With the VM upgrade, the default has changed to clearing the remote element as specified by the RFC. Since we are not ready to promote the public API yet, we should preserve the existing behavior and let addon authors migrate to the new public API directly when it is ready.