Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Failing test for #17963 #18061

Closed
wants to merge 1 commit into from
Closed

WIP: Failing test for #17963 #18061

wants to merge 1 commit into from

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented May 29, 2019

Attempt to reproduce failure in #17963: <LinkTo> without @route param but with @query breaks when navigating to error route

@dgeb
Copy link
Member Author

dgeb commented May 29, 2019

This test is not currently failing, so it may not yet be accurately reproducing #17963.

/cc @buschtoens @rwjblue

Reproduce failure in #17963: `<LinkTo>` without `@route` param but with
`@query` breaks when navigating to error route.

Co-authored-by: Robert Jackson <[email protected]>
@rwjblue rwjblue closed this Jun 14, 2019
@rwjblue
Copy link
Member

rwjblue commented Jun 14, 2019

I fixed up the test (so that it was properly failing), and pushed it to @2hu12's branch for #17971. Once that passes CI, we should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants