Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC beta] remove needless prohibition #16707

Merged
merged 1 commit into from Dec 20, 2018
Merged

[DOC beta] remove needless prohibition #16707

merged 1 commit into from Dec 20, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2018

Originally introduced here:
https://github.com/emberjs/ember.js/pull/4403/files
Discussion question: https://discuss.emberjs.com/t/why-should-i-avoid-transitionto-and-full-urls/14870
This prohibition does not seem necessary so we should remove to avoid
teaching overhead.

@locks locks requested a review from wycats September 10, 2018 11:26
@Turbo87 Turbo87 requested a review from a team December 19, 2018 16:38
@rwjblue
Copy link
Member

rwjblue commented Dec 19, 2018

Seems good to me, but looks like it needs a rebase...

@ghost
Copy link
Author

ghost commented Dec 19, 2018

@rwjblue will do that now.

Originally introduced here:
https://github.com/emberjs/ember.js/pull/4403/files
Discussion question: https://discuss.emberjs.com/t/why-should-i-avoid-transitionto-and-full-urls/14870
This prohibition does not seem necessary so we should remove to avoid
teaching overhead.
@rwjblue rwjblue merged commit c52ea90 into emberjs:master Dec 20, 2018
@ghost ghost deleted the remove-needless-wording branch December 20, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants