Refactor CoreObject to leverage native JS semantics. #16436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pzuraq - This is a slightly different approach than your PR, but has basically the same goal. When you are back in the saddle, can you rebase your tests on top of this branch and see how we do? |
rwjblue
force-pushed
the
core-object-es-spike
branch
from
559aac5 to
07ef267
Compare
rwjblue
force-pushed
the
core-object-es-spike
branch
from
07ef267 to
03dfc91
Compare
|
👍this looks good based on a quick reading on my phone, will rebase the tests as soon as I’m back! |
bekzod
reviewed
Mar 29, 2018
|
|
||
| export function classToString() { | ||
| let name = getName(this); | ||
| if (name !== void 0) { |
There was a problem hiding this comment.
even if it was undefined babel would replace it to void 0, no ?
|
#16437 enables the testing infrastructure to ensure that we stay compliant... |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.extend()actually useclassfor proper inheritanceNAME_KEYto a weakmap