[BUGFIX release] unregister views from viewRegistry (lts-2-8) #14528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sly7-7
reviewed
Oct 27, 2016
| @@ -218,12 +218,12 @@ class Renderer { | |||
| } | |||
|
|
|||
| _register(view) { | |||
| assert('Attempted to register a view with an id already in use: ' + view.elementId, !this._viewRegistry[this.elementId]); | |||
| assert('Attempted to register a view with an id already in use: ' + view.elementId, !view._viewRegistry[this.elementId]); | |||
There was a problem hiding this comment.
this should be this._viewRegistry, but view.elementId right ?
stefanpenner
force-pushed
the
fix-leak-2.8
branch
from
2610da7 to
a382d66
Compare
|
This needs to target |
rwjblue
reviewed
Oct 27, 2016
| @@ -223,7 +223,7 @@ class Renderer { | |||
| } | |||
|
|
|||
| _unregister(view) { | |||
| delete this._viewRegistry[this.elementId]; | |||
| delete this._viewRegistry[view.elementId]; | |||
There was a problem hiding this comment.
Seems fine to change here, but this file isn't used at all on 2.8/2.9 (since the ember-glimmer flag is off).
|
Damn. I'm sorry about this @stefanpenner, I fixed this in #14100 but didn't properly mark it as |
I had forgotten that we can do this via normal Github UI now, I updated. |
rwjblue
changed the title
|
Rebased on top of #14531 (to fix the JSHint errors this was having). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIXES #14526]
needs test(tests added upstream in Ensure view registry entries can be unregistered properly. #14100)