Fix for local lookup of closure components #14421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me! @Serabe - Would you mind reviewing also? |
sglanzer-deprecated
force-pushed
the
release
branch
from
72c3826 to
5e067bd
Compare
|
Missed a semicolon, should pass CI now |
|
Also, just to make it clear to others, this PR is targeting |
|
Should we add a test for rerendering with a different component with different scope? In any case, LGTM. |
|
Good idea! @sglanzer - Would you have time to add that test? |
|
Yeah, I can add that test - so e.g. swap from local to global scope on the rerender? |
|
@sglanzer - Yes, exactly. |
sglanzer-deprecated
force-pushed
the
release
branch
from
5e067bd to
ede16ca
Compare
|
Thank you again @sglanzer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source/module in the env when creating a closure component is correct, but wasn't accessible/used when rendering the closure component in a child context. This fix retains the source/module and sets the env appropriately when a closure component is rendered.