Refactoring curly component argument processing #14355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
☔ The latest upstream changes (presumably #14361) made this pull request unmergeable. Please resolve the merge conflicts. |
ef4
force-pushed
the
refactor-curly-args
branch
from
24b38fc to
b034666
Compare
|
LGTM, @chancancode r? |
|
I want to try to unify this with closure component args, I'll give it a shot today |
|
☔ The latest upstream changes (presumably #13996) made this pull request unmergeable. Please resolve the merge conflicts. |
This cleans up and unifies the handling of curly comopnent arguments. It splits the work into two distinct phases - gatherArgs assembles an EvaluatedArgs that combines all variations of positional and named arguments into a single EvaluatedArgs object - ComponentArgs.create takes the EvaluatedArgs and produces the curly-component specific attrs & props structures with mutable cells, etc.
ef4
force-pushed
the
refactor-curly-args
branch
from
b034666 to
8b691eb
Compare
|
This is rebased against master. @chancancode, can we break your lock and merge this? It doesn't preclude a further refactor that also includes closure component args. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up and unifies the handling of curly component arguments. It splits the work into two distinct phases