Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] failing test for GH#13494 #13891

Merged
merged 1 commit into from
Jul 26, 2016
Merged

[wip] failing test for GH#13494 #13891

merged 1 commit into from
Jul 26, 2016

Conversation

GavinJoyce
Copy link
Member

@miguelcobain
Copy link
Contributor

/cc @asakusuma

@GavinJoyce
Copy link
Member Author

Interestingly, this passes:

['@test GH#13494 tagless blockless component with property binding'](assert) {
    this.registerComponent('foo-bar', {
      ComponentClass: Component.extend({ tagName: '' }),
      template: 'hello {{name}}'
    });

    this.render('{{foo-bar name=name}}', { name: 'Sarah' });

    assert.equal(this.$().text(), 'hello Sarah');

    this.runTask(() => this.rerender());

    assert.equal(this.$().text(), 'hello Sarah');

    this.runTask(() => this.context.set('name', 'Ben'));

    assert.equal(this.$().text(), 'hello Ben');

    this.runTask(() => this.rerender());

    assert.equal(this.$().text(), 'hello Ben');

    this.runTask(() => this.context.set('name', 'Sarah'));

    assert.equal(this.$().text(), 'hello Sarah');
  }

@GavinJoyce
Copy link
Member Author

as does this:

['@test GH#13494 tagless blockless component with property binding'](assert) {
    this.registerComponent('foo-bar', {
      ComponentClass: Component.extend({ tagName: '' })
    });

    this.render('hello {{name}}{{foo-bar name=name}}', { name: 'Sarah' });

    assert.equal(this.$().text(), 'hello Sarah');

    this.runTask(() => this.rerender());

    assert.equal(this.$().text(), 'hello Sarah');

    this.runTask(() => this.context.set('name', 'Ben'));

    assert.equal(this.$().text(), 'hello Ben');

    this.runTask(() => this.rerender());

    assert.equal(this.$().text(), 'hello Ben');

    this.runTask(() => this.context.set('name', 'Sarah'));

    assert.equal(this.$().text(), 'hello Sarah');
  }

@miguelcobain
Copy link
Contributor

Looks like it is somehow related with component nesting then.

@asakusuma
Copy link
Contributor

Thanks guys, I'll get a fix in ASAP

@miguelcobain
Copy link
Contributor

What will happen with ember versions released with this bug? (2.6+)
We will have a bugfix release for them, correct?

@rwjblue
Copy link
Member

rwjblue commented Jul 26, 2016

I would not expect a 2.6 with the fix (it is not an LTS and is no longer the stable version). Assuming the fix is straightforward (aka non-risky) we should get it into 2.7.

@asakusuma
Copy link
Contributor

@rwjblue it's so straightforward I'm a little embarassed

@miguelcobain
Copy link
Contributor

miguelcobain commented Jul 26, 2016

A case where the fix is straightforward, but where it isn't straightforward to reproduce the bug.
Because of that I just thought that "it couldn't be that simple". Lesson learned!

@rwjblue rwjblue merged commit 551bf27 into emberjs:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants