-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] failing test for GH#13494 #13891
[wip] failing test for GH#13494 #13891
Conversation
/cc @asakusuma |
Interestingly, this passes: ['@test GH#13494 tagless blockless component with property binding'](assert) {
this.registerComponent('foo-bar', {
ComponentClass: Component.extend({ tagName: '' }),
template: 'hello {{name}}'
});
this.render('{{foo-bar name=name}}', { name: 'Sarah' });
assert.equal(this.$().text(), 'hello Sarah');
this.runTask(() => this.rerender());
assert.equal(this.$().text(), 'hello Sarah');
this.runTask(() => this.context.set('name', 'Ben'));
assert.equal(this.$().text(), 'hello Ben');
this.runTask(() => this.rerender());
assert.equal(this.$().text(), 'hello Ben');
this.runTask(() => this.context.set('name', 'Sarah'));
assert.equal(this.$().text(), 'hello Sarah');
} |
as does this: ['@test GH#13494 tagless blockless component with property binding'](assert) {
this.registerComponent('foo-bar', {
ComponentClass: Component.extend({ tagName: '' })
});
this.render('hello {{name}}{{foo-bar name=name}}', { name: 'Sarah' });
assert.equal(this.$().text(), 'hello Sarah');
this.runTask(() => this.rerender());
assert.equal(this.$().text(), 'hello Sarah');
this.runTask(() => this.context.set('name', 'Ben'));
assert.equal(this.$().text(), 'hello Ben');
this.runTask(() => this.rerender());
assert.equal(this.$().text(), 'hello Ben');
this.runTask(() => this.context.set('name', 'Sarah'));
assert.equal(this.$().text(), 'hello Sarah');
} |
Looks like it is somehow related with component nesting then. |
Thanks guys, I'll get a fix in ASAP |
What will happen with ember versions released with this bug? (2.6+) |
I would not expect a 2.6 with the fix (it is not an LTS and is no longer the stable version). Assuming the fix is straightforward (aka non-risky) we should get it into 2.7. |
@rwjblue it's so straightforward I'm a little embarassed |
A case where the fix is straightforward, but where it isn't straightforward to reproduce the bug. |
#13494
@miguelcobain
http://localhost:4200/tests/index.html?hidepassed&filter=GH%2313494