Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FunctionMeta to store metadata for functions. #13800

Closed
wants to merge 3 commits into from
Closed

Create FunctionMeta to store metadata for functions. #13800

wants to merge 3 commits into from

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 7, 2016 •
edited
Loading

This allows us to stop holding state information on functions themselves (aka stop treating functions as a "bag of properties").

Once this PR lands we will still be storing these function meta objects on the function itself (in either a WeakMap when supported or on a __ember_function_meta__ property when WeakMap is not present) just like we store normal object meta.

/cc @krisselden

@rwjblue rwjblue force-pushed the add-function-meta branch from d1ccd14 to 1ae6d8d Compare July 8, 2016 12:41
@homu
Copy link
Contributor

homu commented Aug 26, 2016

☔ The latest upstream changes (presumably #14117) made this pull request unmergeable. Please resolve the merge conflicts.

@rwjblue
Copy link
Member Author

rwjblue commented Sep 10, 2016

Just rebased this. It seems likely that we will land #13783 before landing this. If that is what we do, I'll be able to refactor things around to share the setMeta / peekMeta / deleteMeta WeakMap system with fallback for unsupported platforms.

@homu
Copy link
Contributor

homu commented Sep 12, 2016

☔ The latest upstream changes (presumably #14267) made this pull request unmergeable. Please resolve the merge conflicts.

@rwjblue
Copy link
Member Author

rwjblue commented Sep 26, 2016

This PR has been updated to account for changes in the codebase (putting the function-meta implementation into ember-utils package to be used by ember-utils/super), and use native WeakMap when present (along the same lines as #13783 which just landed).

@chancancode - Can you do a run of this against current master in ember-bench so we can confirm no performance regressions?

@krisselden - This is ready for another round of review...

@homu
Copy link
Contributor

homu commented Sep 28, 2016

☔ The latest upstream changes (presumably #14359) made this pull request unmergeable. Please resolve the merge conflicts.

@rwjblue rwjblue force-pushed the add-function-meta branch 2 times, most recently from e081a30 to 923cfd5 Compare September 29, 2016 22:44
rwjblue and others added 3 commits September 29, 2016 18:45
@rwjblue
Create FunctionMeta to store metadata for functions.
d698f00 
This allows us to stop holding state information on functions themselves
(aka stop treating functions as a "bag of properties").

Once this PR lands we will still be storing these function meta objects
on the function itself (in either a `WeakMap` when supported or on a
`__ember_function_meta__` property when `WeakMap` is not present) just
like we store normal object meta.
Use native WeakMap for function meta.
76bde24
Cleanup meta's native WeakMap support.
923cfd5
@machty machty mentioned this pull request Oct 12, 2016
Open
@homu
Copy link
Contributor

homu commented Dec 17, 2016

☔ The latest upstream changes (presumably #14649) made this pull request unmergeable. Please resolve the merge conflicts.

@mmun mmun self-assigned this Feb 25, 2018
@bekzod bekzod mentioned this pull request Apr 30, 2018
Merged
@rwjblue
Copy link
Member Author

rwjblue commented May 1, 2018

replaced by #16595

@rwjblue rwjblue closed this May 1, 2018
@rwjblue rwjblue deleted the add-function-meta branch May 1, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mmun mmun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwjblue @homu @mmun