Cleanup Ember.Test, Ember.testing, Ember.onerror #13440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great @krisselden one more step towards tree shaking. |
krisselden
force-pushed
the
more-global-cleanup
branch
from
a984954 to
5b3aa53
Compare
krisselden
changed the title
|
|
||
| deepEqual(caught, thrown); | ||
|
|
||
| Ember.onerror = undefined; | ||
| setOnerror(undefined); |
There was a problem hiding this comment.
I realize that this was already like this, but we should probably reset in a tear down in case the test dies.
krisselden
force-pushed
the
more-global-cleanup
branch
from
5b3aa53 to
1103968
Compare
| RSVP.configure('async', function(callback, promise) { | ||
| var async = !run.currentRunLoop; | ||
| const backburner = run.backburner; | ||
| run._addQueue('rsvpAfter', 'destroy'); |
There was a problem hiding this comment.
Should we use a private symbol for this? I'd hate for folks to try and schedule into our special queue.
Then again, arguably all of the backburner queues are private so....
|
@krisselden - This looks very good to me. I would like to test ember-qunit with these changes to make sure things work properly. I should be able to finish that tonight or first thing tomorrow morning... |
|
@rwjblue anything I can do to help verify ember-qunit? Would it just be running its test suite against this? I also will update if issues come to light. |
|
☔ The latest upstream changes (presumably #13447) made this pull request unmergeable. Please resolve the merge conflicts. |
krisselden
force-pushed
the
more-global-cleanup
branch
from
1103968 to
d9f57e8
Compare
This was referenced May 5, 2016
rwjblue
added a commit
that referenced
this pull request
Jul 18, 2016
Originally [this line](https://github.com/emberjs/ember.js/blob/3ab8ba2af6551a174f3b91ac9b202bc9f27c09a4/packages/ember-views/lib/system/jquery.js#L8) was checking for a global `require`, but as of #13440 we changed to import or own internal `require`. At the moment, that `require('jquery')` (using our internal loader's version of `require`) will never find a module named `jquery` and will error. I believe we should just remove this guard/check completely. We can always reevaluate if folks still need this for something...
homu
added a commit
that referenced
this pull request
Jul 18, 2016
Remove broken `require('jquery')`.
Originally [this line](https://github.com/emberjs/ember.js/blob/3ab8ba2af6551a174f3b91ac9b202bc9f27c09a4/packages/ember-views/lib/system/jquery.js#L8) was checking for a global `require`, but as of #13440 we changed to import or own internal `require`. At the moment, that `require('jquery')` (using our internal loader's version of `require`) will never find a module named `jquery` and will error.
I believe we should just remove this guard/check completely. We can always reevaluate if folks still need this for something...
/cc @krisselden
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
Originally [this line](https://github.com/emberjs/ember.js/blob/3ab8ba2af6551a174f3b91ac9b202bc9f27c09a4/packages/ember-views/lib/system/jquery.js#L8) was checking for a global `require`, but as of emberjs#13440 we changed to import or own internal `require`. At the moment, that `require('jquery')` (using our internal loader's version of `require`) will never find a module named `jquery` and will error. I believe we should just remove this guard/check completely. We can always reevaluate if folks still need this for something...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.