Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup beta] Move test for Ember.set to observer_test #12894

Merged
merged 1 commit into from
Feb 2, 2016
Merged

[Cleanup beta] Move test for Ember.set to observer_test #12894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 0 additions & 169 deletions packages/ember-metal/tests/keys_test.js
View file
Open in desktop

This file was deleted.

49 changes: 49 additions & 0 deletions packages/ember-metal/tests/observer_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,3 +1166,52 @@ testBoth('observer switched on and off and then setter', function (get, set) {

deepEqual(Object.keys(beer), ['type']);
});

testBoth('observers switched on and off with setter in between (observed property is not shadowing)', function (get, set) {
function Beer() { }

var beer = new Beer();
set(beer, 'type', 'ale');
deepEqual(Object.keys(beer), ['type'], 'only set');

var otherBeer = new Beer();
addObserver(otherBeer, 'type', K);
set(otherBeer, 'type', 'ale');
deepEqual(Object.keys(otherBeer), ['type'], 'addObserver -> set');

var yetAnotherBeer = new Beer();
addObserver(yetAnotherBeer, 'type', K);
set(yetAnotherBeer, 'type', 'ale');
removeObserver(beer, 'type', K);
deepEqual(Object.keys(yetAnotherBeer), ['type'], 'addObserver -> set -> removeOjbserver');

var itsMyLastBeer = new Beer();
set(itsMyLastBeer, 'type', 'ale');
removeObserver(beer, 'type', K);
deepEqual(Object.keys(itsMyLastBeer), ['type'], 'set -> removeObserver');
});

testBoth('observers switched on and off with setter in between (observed property is shadowing one on the prototype)', function (get, set) {
function Beer() { }
Beer.prototype.type = 'ipa';

var beer = new Beer();
set(beer, 'type', 'ale');
deepEqual(Object.keys(beer), ['type'], 'after set');

var otherBeer = new Beer();
addObserver(otherBeer, 'type', K);
set(otherBeer, 'type', 'ale');
deepEqual(Object.keys(otherBeer), ['type'], 'addObserver -> set');

var yetAnotherBeer = new Beer();
addObserver(yetAnotherBeer, 'type', K);
set(yetAnotherBeer, 'type', 'ale');
removeObserver(beer, 'type', K);
deepEqual(Object.keys(yetAnotherBeer), ['type'], 'addObserver -> set -> removeObserver');

var itsMyLastBeer = new Beer();
set(itsMyLastBeer, 'type', 'ale');
removeObserver(beer, 'type', K);
deepEqual(Object.keys(itsMyLastBeer), ['type'], 'set -> removeObserver');
});