Ignore ember-extension-support phantom crashes #12879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] The current verison of phantomjs no longer prints noisy messages
to stderr, dropping the check
- [x] Don't supress phantomjs error message when it crashes
- [x] Retry up to 3 times when phantomjs crashes
- [x] Use `minidump_stackwalk` to print the phantomjs stack trace when
it crashes
chancancode
force-pushed
the
skip-ember-extension-support
branch
from
c642494 to
512521a
Compare
rwjblue
added a commit
that referenced
this pull request
Jan 31, 2016
Ignore ember-extension-support phantom crashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #12878.
The additional change here is to ignore the crashes when testing the
ember-extension-supportpackage, which allows the rest of the test suite to keep running. This is likely a very specific bug in phantom 1.9.8, since the other rows in the build matrix are green (so we know Ember and the test suite runs just fine on phantom).Hopefully we will find a solution for this soon. We have the stack trace now, so we can send a crash report to phantom. However, since there are almost 60 open issues for 1.9.8 crashes, and since they have moved on to developing phantom 2.x, I bet the chance of getting this particular issue fixed is quite low.