Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use weakmap for non internal meta #12417

Closed
wants to merge 2 commits into from
Closed

Use weakmap for non internal meta #12417

wants to merge 2 commits into from

Conversation

stefanpenner
Copy link
Member

  • make tests pass
  • benchmarks (now that chrome doesn't crash when using meta)
  • rename readMeta -> peekMeta

@mmun mmun mentioned this pull request Feb 20, 2016
Merged
@mmun
Copy link
Member

mmun commented Feb 21, 2016

@stefanpenner Should this be closed now?

@rwjblue
Copy link
Member

rwjblue commented Apr 10, 2016

Replaced by #12990, which has landed.

@rwjblue rwjblue closed this Apr 10, 2016
@rwjblue rwjblue deleted the use-weakmap-for-non-internal-meta branch April 10, 2016 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanpenner @mmun @rwjblue