Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayComputed issues #9462

Closed
7 tasks
wagenet opened this issue Nov 1, 2014 · 5 comments
Closed
7 tasks

ArrayComputed issues #9462

wagenet opened this issue Nov 1, 2014 · 5 comments

Comments

@wagenet
Copy link
Member

wagenet commented Nov 1, 2014

PRs:

@patricklx
Copy link
Contributor

Is there work being done on array computed or reduce computed?
Else, i can do something ;). Currently i have some free time.

I read somewhere that, for example, beforeObserver will be deprecated. So reduce computed must be adapted.

I also see some possible optimizations in reduce computed, e.g. use run.once to coalescence the item changes. But a get could still flush them directly and get the new value

Some array computed macros could make use of flushedChanges to detect if an item really needs to be removed, currently they are removed and added again.

Finally value changes could only be triggered once, after flushedChanges. Currently it is done on every setValue

@mmun
Copy link
Member

mmun commented Nov 6, 2014

@patricklx ping me on IRC if you want to chat about this. I'm mmun on #emberjs-dev.

@estshy
Copy link

estshy commented Nov 19, 2014

Is there any chance that those errors would be fixed in incoming release? I'm waiting to deploy an application to production and it's necessary for it to get array computed worked properly ;)

@wagenet
Copy link
Member Author

wagenet commented Dec 17, 2014

@estshy Unfortunately, many of these issues may necessitate a more significant overhaul so I can't give an ETA at the moment. We'd love to hear from people interested in helping out though.

@Serabe
Copy link
Member

Serabe commented Mar 23, 2015

@wagenet I might be one of those people. I'm skimming through the code trying to get to understand it and having a goal might help me.

stefanpenner added a commit that referenced this issue Jun 23, 2015
#9492, #5319, #5268, #4831] Move away from AC/RC instead use the simpler naive enumerable methods, and rely on glimmers stable rendering for efficiency.

For more complex scenarios, custom solutions should be used.

@wagenet & @stefanpenner
stefanpenner added a commit to stefanpenner/ember.js that referenced this issue Jun 26, 2015
…rjs#9462, emberjs#4919, emberjs#4231, emberjs#3706, emberjs#5596, emberjs#9485, emberjs#9492, emberjs#5319, emberjs#5268, emberjs#4831, emberjs#5558] Move away from AC/RC instead use the simpler naive enumerable methods, and rely on glimmers stable rendering for efficiency.

For more complex scenarios, custom solutions should be used.

@wagenet & @stefanpenner
stefanpenner added a commit that referenced this issue Jun 28, 2015
#5596, #9485, #9492, #5319, #5268, #4831, #5558] Move away from AC/RC instead use the simpler naive enumerable methods, and rely on glimmers stable rendering for efficiency.

For more complex scenarios, custom solutions should be used.

@wagenet & @stefanpenner

(cherry picked from commit 0dc1a6c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants