Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tryInvoke, canInvoke, compare, isEqual missing updated imports in docs #16079

Closed
jenweber opened this issue Jan 6, 2018 · 2 comments
Closed

tryInvoke, canInvoke, compare, isEqual missing updated imports in docs #16079

jenweber opened this issue Jan 6, 2018 · 2 comments

Comments

@jenweber
Copy link
Contributor

jenweber commented Jan 6, 2018

According to RFC176 these should be part of the @ember/utils module, but API docs do not reflect this. I think they just got overlooked.

Documentation block here

Should follow the same pattern as this example with a class and fixed method

Update ought to target 2.18 LTS candidate and later
@jenweber jenweber mentioned this issue Jan 6, 2018
Merged
@jenweber
Copy link
Contributor Author

jenweber commented Jan 6, 2018 •
edited
Loading

PR #16080

@jenweber jenweber changed the title tryInvoke and canInvoke missing updated imports in docs tryInvoke, canInvoke, compare, isEqual missing updated imports in docs Jan 7, 2018
toddjordan added a commit that referenced this issue Jan 8, 2018
@toddjordan
Merge pull request #16080 from jenweber/bugfix-tryinvoke-caninvoke-utils
db34024 
[BUGFIX] missing modules docs for tryInvoke, compare, isEqual #16079
kategengler pushed a commit that referenced this issue Jan 8, 2018
@jenweber @kategengler
[BUGFIX] modules docs for tryInvoke, compare, isEqual #16079
774862e 
(cherry picked from commit 689ffc5)
@locks
Copy link
Contributor

locks commented Jan 9, 2018

Addressed by PR mentioned above.

@locks locks closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@locks @jenweber