Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blueprints for "ember-cli-mocha >= 0.12.0" #14667

Closed
Turbo87 opened this issue Dec 1, 2016 · 5 comments
Closed

Add blueprints for "ember-cli-mocha >= 0.12.0" #14667

Turbo87 opened this issue Dec 1, 2016 · 5 comments

Comments

@Turbo87
Copy link
Member

Turbo87 commented Dec 1, 2016

[email protected] introduced a new testing API and deprecated the old describeXXX() helpers. The blueprints in this repository need to be updated to reflect those changes.

Instead of just updating we should make sure that uses with all versions of ember-cli-mocha get the right blueprints. We can accomplish that by checking the installed version of ember-cli-mocha using a VersionChecker and then deciding whether to use the mocha-files or mocha-0.12-files blueprints folder.

The tracking issue for this is ember-cli/ember-cli-mocha#142

@rwjblue
Copy link
Member

rwjblue commented Dec 1, 2016

Sounds like a good plan to me...

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 1, 2016

@rwjblue can we target the beta branch with this change?

@rwjblue
Copy link
Member

rwjblue commented Dec 1, 2016

Assuming it lands within the next couple weeks, yes. But you would target master branch with a commit prefixed by [BUGFIX beta].

@cs3b
Copy link

cs3b commented Feb 24, 2017

what about acceptance tests? shouldn't we add template for >= 0.12.0 ?

https://github.com/emberjs/ember.js/tree/master/blueprints/acceptance-test

@rwjblue
Copy link
Member

rwjblue commented Feb 24, 2017

@cs3b - In general, commenting on a previously closed issue is going to be missed. Please open a new issue with an explanation of the issue you are seeing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants