[BUGFIX beta] Add blueprints for "ember-cli-mocha >= 0.12.0" #14670
Conversation
|
discovered a small issue with this, do not merge for now... 😞 |
| semver.satisfies('0.12.0', dependencies['ember-cli-mocha'])) { | ||
| type = 'mocha-0.12'; | ||
| } else { | ||
| type = 'mocha'; |
There was a problem hiding this comment.
I think we need to flip-flop this logic, I (and I could be going out on a limb here) think that the new syntax will likely stay around even if we have to make a 0.13 / 1.0 / etc of ember-mocha. We should update this conditional so the else is the new format.
I'd also suggest mocha-current and mocha-lt-0.12 as the folder paths.
Thoughts?
There was a problem hiding this comment.
@rwjblue that is precisely what I meant with "small issue" above. I've fixed it in emberjs/data#4691 by using the VersionChecker class and generating fake package manifests for the mocha blueprint tests. will update this PR now too.
There was a problem hiding this comment.
@rwjblue this should be resolved now
There was a problem hiding this comment.
regarding the folder names: I wanted to keep the diff small, so I decided to leave the old blueprints at their original location
Turbo87
force-pushed
the
mocha-blueprints
branch
from
95b563f to
8892901
Compare
Turbo87
force-pushed
the
mocha-blueprints
branch
from
8892901 to
f150729
Compare
Resolves #14667
/cc @rwjblue @patsy-issa