Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Need better example for Route#loading #13341

Closed
James1x0 opened this issue Apr 15, 2016 · 1 comment
Closed

[DOC] Need better example for Route#loading #13341

James1x0 opened this issue Apr 15, 2016 · 1 comment
Labels
Bug Documentation

Comments

@James1x0
Copy link

https://github.com/emberjs/ember.js/blob/v2.5.0/packages/ember-routing/lib/system/route.js#L615-L622
Uses deprecated Ember.View API in the example. I would bet this is confusing to new users coming to Ember and seeing this hook.
@rwjblue
Copy link
Member

rwjblue commented Apr 15, 2016

WOAH! That is a horrible example! Thank you for pointing that out...

@duggiefresh duggiefresh mentioned this issue Apr 15, 2016
Merged
duggiefresh added a commit to duggiefresh/ember.js that referenced this issue Apr 15, 2016
@duggiefresh
[DOC beta] Update Route#loading example
c4b20e3 
Fixes emberjs#13341
wycats pushed a commit that referenced this issue Apr 25, 2016
@duggiefresh
[DOC beta] Update Route#loading example
3539c6c 
Fixes #13341

(cherry picked from commit c4b20e3)
toddjordan pushed a commit to toddjordan/ember.js that referenced this issue Sep 9, 2016
@duggiefresh @toddjordan
[DOC beta] Update Route#loading example
035935f 
Fixes emberjs#13341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @Serabe @James1x0