transitionTo returns promise when passed a url

[asakusuma]

In ember canary, route.transitionTo returns a promise when passed a url. According to the docs, it should return a transition object.

From what I can tell, the issue seems to have been introduced in this commit.

I reproduced the issue in this example app.

cc @minasmart @rwjblue

[rwjblue]

Thanks for the report @asakusuma, looks like @GavinJoyce is working on a fix in #12905.

[GavinJoyce]

I had been digging into the recent changes which reshuffled how the router deals with exceptions but I don't have enough context yet to be productive here.

Sorry, I'm going to close my skeleton PR and find something else to work on.

[rwjblue]

@GavinJoyce - Understood. I'm trying to find a good path forward. I realize this is a fairly bad regression, so I'll try to be quick about it...

[krisselden]

Mobile phone mishap

[krisselden]

Was just scrolling somehow registered as a tap on the close button

[stefanpenner]

Mobile phone mishap

rofl #theWeb

[minasmart]

@rwjblue & @GavinJoyce the skeleton PR looks good to me. I don't think it breaks exception handling. Did all the tests pass with the change?

[rwjblue]

@minasmart - It breaks most of the tests I added in the original PR.

[minasmart]

aw 😢

[minasmart]

I'll spend some time and see if I can maybe come up with some ideas? I feel a little responsible having wrote the code that caused the regression.

[asakusuma]

@krisselden briefed me on the issue. I'm going to take a stab at a PR this afternoon and will give an update later today.

[asakusuma]

@rwjblue @krisselden @minasmart any objection to making router.transitionTo public? route.transitionTo is public, and it's pretty much just a proxy to router.transitionTo: https://github.com/emberjs/ember.js/blob/master/packages/ember-routing/lib/system/route.js#L1027

Edit: formatting