Skip to content

Commit

Permalink
[CLEANUP beta] Remove long deprecated {{linkTo}} helper.
Browse files Browse the repository at this point in the history
This was deprecated prior to 1.0.0.

This is **NOT** removing `{{link-to}}`.
  • Loading branch information
rwjblue committed Jul 1, 2015
1 parent 4cc1384 commit f3da227
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 46 deletions.
12 changes: 0 additions & 12 deletions packages/ember-routing-htmlbars/lib/keywords/link-to.js
Original file line number Diff line number Diff line change
Expand Up @@ -305,15 +305,3 @@ export default {
this.render(morph, env, scope, params, hash, template, inverse, visitor);
}
};

/**
See [link-to](/api/classes/Ember.Handlebars.helpers.html#method_link-to)
@method linkTo
@for Ember.Handlebars.helpers
@deprecated
@param {String} routeName
@param {Object} [context]*
@return {String} HTML string
@private
*/
12 changes: 0 additions & 12 deletions packages/ember-routing-htmlbars/lib/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/

import Ember from 'ember-metal/core';
import merge from 'ember-metal/merge';

import { registerHelper } from 'ember-htmlbars/helpers';
import { registerKeyword } from 'ember-htmlbars/keywords';
Expand All @@ -22,15 +21,4 @@ registerKeyword('@element_action', elementAction);
registerKeyword('link-to', linkTo);
registerKeyword('render', render);

var deprecatedLinkTo = merge({}, linkTo);
merge(deprecatedLinkTo, {
link(state, params, hash) {
linkTo.link.call(this, state, params, hash);
Ember.deprecate('The \'linkTo\' view helper is deprecated in favor of \'link-to\'');
}
});


registerKeyword('linkTo', deprecatedLinkTo);

export default Ember;
22 changes: 0 additions & 22 deletions packages/ember/tests/helpers/link_to_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -897,28 +897,6 @@ QUnit.test('The {{link-to}} helper\'s bound parameter functionality works as exp
equal(normalizeUrl($link.attr('href')), '/posts/2', 'self link updated to post 2');
});

QUnit.test('{{linkTo}} is aliased', function() {
Ember.TEMPLATES.index = compile('<h3>Home</h3>{{#linkTo \'about\' id=\'about-link\' replace=true}}About{{/linkTo}}');

Router.map(function() {
this.route('about');
});

expectDeprecation(function() {
bootApplication();
}, 'The \'linkTo\' view helper is deprecated in favor of \'link-to\'');

Ember.run(function() {
router.handleURL('/');
});

Ember.run(function() {
Ember.$('#about-link', '#qunit-fixture').click();
});

equal(container.lookup('controller:application').get('currentRouteName'), 'about', 'linkTo worked properly');
});

QUnit.test('The {{link-to}} helper is active when a route is active', function() {
Router.map(function() {
this.route('about', function() {
Expand Down

0 comments on commit f3da227

Please sign in to comment.