removed transform-input-on-to-onEvent

emberjs · Dec 1, 2017 · c83a668 · c83a668
1 parent 1723b73
commit c83a668
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 211 deletions.
diff --git a/packages/ember-template-compiler/lib/plugins/index.js b/packages/ember-template-compiler/lib/plugins/index.js
@@ -1,6 +1,5 @@
 import TransformOldBindingSyntax from './transform-old-binding-syntax';
 import TransformAngleBracketComponents from './transform-angle-bracket-components';
-import TransformInputOnToOnEvent from './transform-input-on-to-onEvent';
 import TransformTopLevelComponents from './transform-top-level-components';
 import TransformInlineLinkTo from './transform-inline-link-to';
 import TransformOldClassBindingSyntax from './transform-old-class-binding-syntax';
@@ -24,7 +23,6 @@ const transforms = [
   TransformDotComponentInvocation,
   TransformOldBindingSyntax,
   TransformAngleBracketComponents,
-  TransformInputOnToOnEvent,
   TransformTopLevelComponents,
   TransformInlineLinkTo,
   TransformOldClassBindingSyntax,

diff --git a/packages/ember-template-compiler/lib/plugins/transform-input-on-to-onEvent.js b/packages/ember-template-compiler/lib/plugins/transform-input-on-to-onEvent.js
diff --git a/packages/ember-template-compiler/tests/plugins/transform-input-on-test.js b/packages/ember-template-compiler/tests/plugins/transform-input-on-test.js
diff --git a/packages/ember-views/lib/mixins/text_support.js b/packages/ember-views/lib/mixins/text_support.js
@@ -142,35 +142,6 @@ export default Mixin.create(TargetActionSupport, {
     this.on('input', this, this._elementValueDidChange);
   },
 
-  /**
-    The action to be sent when the user presses the return key.
-
-    This is similar to the `{{action}}` helper, but is fired when
-    the user presses the return key when editing a text field, and sends
-    the value of the field as the context.
-
-    @property action
-    @type String
-    @default null
-    @private
-  */
-  action: null,
-
-  /**
-    The event that should send the action.
-
-    Options are:
-
-    * `enter`: the user pressed enter
-    * `keyPress`: the user pressed a key
-
-    @property onEvent
-    @type String
-    @default enter
-    @private
-  */
-  onEvent: 'enter',
-
   /**
     Whether the `keyUp` event that triggers an `action` to be sent continues
     propagating to other views.
@@ -335,21 +306,11 @@ export default Mixin.create(TargetActionSupport, {
 // the component semantics so this method normalizes them.
 function sendAction(eventName, view, event) {
   let action = get(view, `attrs.${eventName}`) || get(view, eventName);
-  let on = get(view, 'onEvent');
   let value = get(view, 'value');
 
-  // back-compat support for keyPress as an event name even though
-  // it's also a method name that consumes the event (and therefore
-  // incompatible with sendAction semantics).
-  if (on === eventName || (on === 'keyPress' && eventName === 'key-press')) {
-    view.sendAction('action', value);
-  }
-
   view.sendAction(eventName, value);
 
-  if (action || on === eventName) {
-    if (!get(view, 'bubbles')) {
-      event.stopPropagation();
-    }
+  if (action && !get(view, 'bubbles')) {
+    event.stopPropagation();
   }
 }