Skip to content

Commit

Permalink
[BUGFIX beta] [FEATURE EMBER_GLIMMER_ARRAY_HELPER] Add feature flagging.
Browse files Browse the repository at this point in the history
This feature was accidentally landed without feature flagging (:sob:),
this commit adds feature flagging (defaulting to off unless manually
enabled).
  • Loading branch information
rwjblue committed Dec 7, 2018
1 parent 8f7da77 commit bc58242
Show file tree
Hide file tree
Showing 3 changed files with 186 additions and 177 deletions.
6 changes: 5 additions & 1 deletion packages/@ember/-internals/glimmer/lib/resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
EMBER_MODULE_UNIFICATION,
GLIMMER_CUSTOM_COMPONENT_MANAGER,
GLIMMER_MODIFIER_MANAGER,
EMBER_GLIMMER_ARRAY_HELPER,
} from '@ember/canary-features';
import { assert } from '@ember/debug';
import { _instrumentStart } from '@ember/instrumentation';
Expand Down Expand Up @@ -66,7 +67,6 @@ const BUILTINS_HELPERS = {
concat,
get,
hash,
array,
log,
mut,
'query-params': queryParams,
Expand All @@ -84,6 +84,10 @@ const BUILTINS_HELPERS = {
'-assert-implicit-component-helper-argument': componentAssertionHelper,
};

if (EMBER_GLIMMER_ARRAY_HELPER) {
BUILTINS_HELPERS['array'] = array;
}

const BUILTIN_MODIFIERS = {
action: { manager: new ActionModifierManager(), state: null },
};
Expand Down
Loading

0 comments on commit bc58242

Please sign in to comment.