Skip to content

Commit

Permalink
Merge pull request #9311 from jayphelps/oops
Browse files Browse the repository at this point in the history
[BUGFIX] Canary FEATURES flagging shouldn't produce warnings in canary
  • Loading branch information
rwjblue committed Oct 14, 2014
2 parents bfff16b + 116434f commit 2178406
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions features.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"features": {
"features-stripped-test": null,
"ember-routing-named-substates": null,
"ember-routing-add-model-option": true,
"ember-routing-linkto-target-attribute": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-debug/lib/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ export function _warnIfUsingStrippedFeatureFlags(FEATURES, featuresWereStripped)
Ember.warn('Ember.ENV.ENABLE_OPTIONAL_FEATURES is only available in canary builds.', !Ember.ENV.ENABLE_OPTIONAL_FEATURES);

for (var key in FEATURES) {
if (FEATURES.hasOwnProperty(key)) {
if (FEATURES.hasOwnProperty(key) && key !== 'isEnabled') {
Ember.warn('FEATURE["' + key + '"] is set as enabled, but FEATURE flags are only available in canary builds.', !FEATURES[key]);
}
}
Expand Down

0 comments on commit 2178406

Please sign in to comment.