-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add numbers to keyFromKeyCode #391
Conversation
Adding a number key test-case seems good |
Looks good to me, it just needs tests. |
The keyCodes for number pad are the same. I'll get on the test(s) |
Added tests for numbers. Let me know if there are any more concerns. |
@cibernox I wanted to clarify re:keycodes between the top row and number pad: The ASCII code ( |
Thank you! |
Ran into an issue where I needed the numbers to in the keycode list as well (height/weight form).
Fixes #390