Update ember-try #145
Closed
Update ember-try #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for working on this! |
| // altough since 2.3 ember-data is a proper addon which is installed | ||
| // via npm; we are setting the version for the bower dependency here | ||
| // so we make sure that ember-data 2.3 is used. This can be removed | ||
| // once there is support for removing dependencies in an ember-try |
There was a problem hiding this comment.
Let's remove ember-data from the default bower.json and add it to each scenario. That way we do not need ember-try to support removing...
This was referenced Jan 31, 2016
|
Closing in favor of #148. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the latest version of ember-try, we can change dependencies of
npm packages too. This is useful for the ember-data-2.3 scenario,
because ember-data 2.3 is an addon, which needs to be installed via npm
instead of bower.
TODO
ember-data-2.3scenario so it usesember-datanpm package