Merge pull request #392 from gabrielgrant/add-selector-to-wait-for-de…

…fault-timeout-message Include selector in waitFor()'s default timeout message
emberjs · Jul 9, 2018 · e172fe6 · e172fe6
2 parents 47b094d + c13946a
commit e172fe6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/addon-test-support/@ember/test-helpers/dom/wait-for.js b/addon-test-support/@ember/test-helpers/dom/wait-for.js
@@ -15,14 +15,14 @@ import { nextTickPromise } from '../-utils';
   @param {number} [options.count=null] the number of elements that should match the provided selector (null means one or more)
   @return {Promise<Element|Element[]>} resolves when the element(s) appear on the page
 */
-export default function waitFor(
-  selector,
-  { timeout = 1000, count = null, timeoutMessage = 'waitFor timed out' } = {}
-) {
+export default function waitFor(selector, { timeout = 1000, count = null, timeoutMessage } = {}) {
   return nextTickPromise().then(() => {
     if (!selector) {
       throw new Error('Must pass a selector to `waitFor`.');
     }
+    if (!timeoutMessage) {
+      timeoutMessage = `waitFor timed out waiting for selector "${selector}"`;
+    }
 
     let callback;
     if (count !== null) {

diff --git a/tests/unit/dom/wait-for-test.js b/tests/unit/dom/wait-for-test.js
@@ -75,7 +75,7 @@ module('DOM Helper: waitFor', function(hooks) {
     } catch (error) {
       let end = Date.now();
       assert.ok(end - start >= 100, 'timed out after correct time');
-      assert.equal(error.message, 'waitFor timed out');
+      assert.equal(error.message, 'waitFor timed out waiting for selector ".something"');
     }
   });