Require project to provide @ember/test-helpers and qunit.
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves `@ember/test-helpers` and `qunit` from `dependencies` to `peerDependencies`, and ensures those peer dependencies are satisfied by the host application. This allows the host application to control the precise `@ember/test-helpers` and `qunit` versions, and better positions our users to leverage Embroider/ember-auto-import style "automatic" imports. Also to note, `npm@7` will aid us here and ensure that peer dependencies are installed.
rwjblue
commented
Aug 17, 2020
| ); | ||
| } | ||
|
|
||
| // TODO: remove these `this.import` statements when the app is using using Embroider or ember-auto-import |
There was a problem hiding this comment.
@ef4 - I'm not 100% sure how to do this, curious if you have thoughts...
(note: I still plan to land this change since it doesn't require automatic Embroider/ember-auto-import interop initially)
|
Big 👍 from me. This is a big pain point right now, as you have to either upgrade |
scalvert
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
@ember/test-helpersandqunitfromdependenciestopeerDependencies, and ensures those peer dependencies are satisfied by the host application.This allows the host application to control the precise
@ember/test-helpersandqunitversions, and better positions our users to leverage Embroider/ember-auto-import style "automatic" imports.Also to note,
npm@7will aid us here and ensure that peer dependencies are installed.For applications migrating, run the following (choose the version that applies to your app):