Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode deps #1098

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Strict mode deps #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc10a64
Add strict-mode settings for library-dev per RFC#907
NullVoxPopuli Jun 12, 2023
d40fdc9
Ignore when webpack is missing in the addon, because it's a goofy sid…
NullVoxPopuli Jun 12, 2023
d892573
Move type tests to their own package so that the test-dependencies do…
NullVoxPopuli Jun 12, 2023
ebe8d32
Update lockfile post-rebase
NullVoxPopuli Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ jobs:
ts-version:
- 4.8
- 4.9
- 5.0
- 5.1
- next

steps:
Expand All @@ -82,4 +84,4 @@ jobs:
working-directory: addon
- name: test types
run: pnpm test:types
working-directory: addon
working-directory: test-types
8 changes: 8 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# these settings allow us to be good stewards of the ecosystem
# end-consumers can flip these settings in their own projects,
# but library authors should not allow for less-than-strictest
# behavior.
#
# For more information: https://pnpm.io/npmrc
auto-install-peers=false
resolve-peers-from-workspace-root=false
3 changes: 0 additions & 3 deletions addon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"lint:js": "eslint . --cache",
"lint:js:fix": "eslint . --fix",
"start": "rollup --config --watch",
"test:types": "tsc --noEmit --project types",
"prepack": "rollup --config"
},
"dependencies": {
Expand All @@ -52,8 +51,6 @@
"@types/qunit": "^2.19.4",
"@types/rsvp": "^4.0.4",
"concurrently": "^8.0.1",
"ember-cli-htmlbars": "^6.2.0",
"ember-resolver": "^10.1.0",
"ember-source": "^4.10.0",
"eslint": "^8.42.0",
"eslint-config-prettier": "^8.6.0",
Expand Down
11 changes: 0 additions & 11 deletions addon/types/tsconfig.json
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,12 @@
"volta": {
"node": "18.16.0",
"pnpm": "8.6.2"
},
"pnpm": {
"peerDependencyRules": {
"ignoreMissing": [
"webpack"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added because ember-qunit depends on ember-source, which declared webpack as a peerDependency.
This makes sense for apps, but not for v2 addons.

The webpack peerdep in ember-source will also go away once it itself is converted to a v2 addon

]
}
}
}
Loading