Ember >= 4.x compatibility (require ember-source 4.8+)

[void-mAlex]

motivation for this is that @ember/legacy-built-in-components is a peer dep for ember-engines for "ember-source": "^3.24.1 || 4",
in ember-source: 4 sendAction was rightly cleaned up and the named export is no longer resolvable which can cause warnings at best and errors at worst (trying to run an ember-engine while using a LinkTo component on ember source 4.x)

with this PR I propose we close that gap by releasing a new major for @ember/legacy-built-in-components to be used with ember-source >= 4.x

[SergeAstapov]

tbh not sure it worth the churn and effort. maybe I'm missing if there is an actual issue this PR fixes?

[void-mAlex]

the short answer is I believe it to be worth the effort.
the actual issue is with running engines with embroider under vite. this is an error in that case and your app doesn't load at all because the import it's doing is not valid on ember-source > 3.x
the alternative would be to pr a change to engines to work without LinkTo component for example or any of the components provided by this addon

[SergeAstapov]

the actual issue is with running engines with embroider under vite

sounds reasonable!

the alternative would be to pr a change to engines to work without LinkTo component for example or any of the components provided by this addon

it means copy-pasting pasts of this addon.
we tried to brainstorm ideas how to move forward without using something old LinkTo component and came up with emberjs/rfcs#819 which was put on hold as there is larger router initiative as part of Polaris.

[SergeAstapov]

I wonder if @mixonic is ok to land this and get new major out.

@void-mAlex I would say, we need to provide peerDeps on ember-source: >= 4 then + update readme as well as ember-try scenarios?

[void-mAlex]

ok will try and get those done

regarding the failing ember-try scenario for ember-beta
I think either adding @glint/template to dev dependencies of the addon or configuring the scenario to install it for that run would fix it
any preference on the approach?

[SergeAstapov]

@void-mAlex either should be fine IMO. Thank you!

[void-mAlex]

@mixonic @SergeAstapov I managed to get ci green as well
bumped peer declaration to be ember-source >=4
updated readme to reflect that
ember-beta is running against 5.x series so the loose peer declaration should be correct/ok to leave open for future ember version

this would unblock engines continuing to work through the 4.x and 5.x ember source version especially through embrodier

let me know if I missed something or anything else I need to do to land this.
thank you in advance