Avoid triggering Component reopen deprecation #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember.Component.reopen is deprecated with the id ember.component.reopen to be removed in Ember 4.0. Here, use a clever invocation to avoid the Ember deprecation. Both these APIs are deprecated targeting 4.0 anyway, so this deprecation doesn't need to exist after Component.reopen is removed.
mixonic
added a commit
to ember-cli/ember-cli-deprecation-workflow
that referenced
this pull request
Jun 4, 2021
Via inclusion of emberjs/ember-jquery#326
chancancode
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.Component.reopenis deprecated with the idember.component.reopento be removed in Ember 4.0. Here, use a clever invocation to avoid the Ember deprecation.Both these APIs are deprecated targeting 4.0 anyway, so this deprecation doesn't need to exist after
Component.reopenis removed.The avoidance of the deprecation is demonstrated by a green CI suite at ember-cli/ember-cli-deprecation-workflow#125 which would fail (with an exception of an unhandled deprecation) if the reopen deprecation were still triggered.
cc @chancancode @simonihmig