Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly forward the browsers targets to ember-preset-env #122

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

kanongil
Copy link
Contributor

Currently they are completely ignored.

@cibernox
Copy link
Contributor

I just wonder if we can create a test harness that ember-cli-babel honour targets.

@rwjblue
Copy link
Member

rwjblue commented Mar 21, 2017

@kanongil - How embarrassing, thank you for digging and submitting the fix!

@cibernox - Ya, we have a bunch of node-tests already, I'll add one to confirm preset env is generally working (pass a specific set of targets and confirm various plugins are not used).

@rwjblue rwjblue merged commit 60d12de into emberjs:master Mar 21, 2017
@Turbo87 Turbo87 added the bug label Oct 27, 2017
siva-sundar pushed a commit to siva-sundar/ember-cli-babel that referenced this pull request Feb 11, 2021
Explain usage to people not familiar with Babel 6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants