Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #60: Add build time flags for deprecation toggling #62

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Fixes #60: Add build time flags for deprecation toggling #62

merged 2 commits into from
Mar 12, 2018

Conversation

thoov
Copy link
Member

@thoov thoov commented Feb 13, 2018 •
edited
Loading

Allows individual deprecations to be turned on and off via:

new EmberApp(defaults, {
  'ember-2-legacy': {
    'underscore-actions-support': false,
    // etc...
  }
});

@thoov thoov requested a review from rwjblue February 13, 2018 00:27
@thoov thoov changed the title Fixes #60: Add build time flags for deprecation toggling [WIP] Fixes #60: Add build time flags for deprecation toggling Feb 14, 2018
@thoov thoov changed the title [WIP] Fixes #60: Add build time flags for deprecation toggling Fixes #60: Add build time flags for deprecation toggling Feb 14, 2018
thoov
thoov commented Feb 14, 2018
View reviewed changes
index.js Outdated
// before the options from EmberApp are provided. There currently is no way of handling
// this case other than manually messing with configCache or modifing the dom by setting
// up window.EmberENV before ember loads.
if (!config.get(env)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwjblue Can you take a look at this. This is the hacky bit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, can we use this.project.config(env) to prime the cache?

@thoov thoov merged commit 8fabc06 into emberjs:master Mar 12, 2018
@thoov thoov deleted the flags branch March 12, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thoov @rwjblue