Add deprecated registry property to Application/ApplicationInstance
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
force-pushed
the
port-deprecated-registry
branch
from
78f91a8 to
74cd63e
Compare
|
@cibernox Could you move the test that you removed from https://github.com/emberjs/ember.js/pull/15912/files#diff-7ed395980aff799efa70007547a47210 into this? |
|
Also needs a rebase |
|
@cibernox - Ping? |
cibernox
force-pushed
the
port-deprecated-registry
branch
from
74cd63e to
f6c2b9d
Compare
|
I somehow missed notifications about this. Done. |
thoov
reviewed
Dec 11, 2017
| }); | ||
|
|
||
| test('properties (and aliases) are correctly assigned for accessing the container and registry', function(assert) { | ||
| assert.expect(6); |
There was a problem hiding this comment.
I'm counting 7 assertions here. Can you verify that we are hitting all of them?
cibernox
force-pushed
the
port-deprecated-registry
branch
from
f6c2b9d to
7d648bd
Compare
|
@thoov I think this is ready now. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal in emberjs/ember.js#15912