fix: prevent rollbackRelationships from setting remoteState and localState to the same array reference #9221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…State to the same array reference
runspired
added
🎯 release
gitKrystan
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9207
Adds the test from that PR. Root cause is that typically we can presume
replaceRelatedRecordsis receiving an array reference it can safely re-use for localState/remoteState as appropriate. However in this case we generate the operation from the existing remoteState array and so this led to the two arrays having the same reference.This meant that the next mutation on localState was then partially reflected into remoteState, preventing rollbackRelationships from working properly. Only partially reflected because the bookkeeping sets would still see this relationship as empty remotely.