chore: Type check test files

CHANGELOG.md

@@ -99,7 +99,7 @@
   * fix: de-dupe coalescing when includes or adapterOptions is present but still use findRecord #8704
   * fix: make implicit relationship teardown following delete of related record safe #8705
   * fix: catch errors during didCommit in DEBUG #8708
-  
+
 ## 5.1.1 (2023-07-07)
 
 #### :bug: Bug Fix
@@ -3053,7 +3053,7 @@ The full API reference of `DS.Snapshot` can be found [here](https://api.emberjs.
 - fetch() -> fetchById() in docs
 - Run findHasMany inside an ED runloop
 - Cleanup debug adapter test: Watching Records
-- Fixed didDelete event/callback not fired in uncommited state
+- Fixed didDelete event/callback not fired in uncommitted state
 - Add main entry point for package.json.
 - register the store as a service
 - Warn when expected coalesced records are not found in the response

package.json

@@ -9,7 +9,8 @@
   "scripts": {
     "takeoff": "FORCE_COLOR=2 pnpm install --reporter=append-only",
     "prepare": "pnpm build",
-    "build": "turbo _build --log-order=stream --filter=./packages/*",
+    "build": "turbo _build --log-order=stream --filter=./packages/* --concurrency=1; pnpm run sync:tests",
+    "sync:tests": "pnpm run --filter=./tests/* -r --workspace-concurrency=1 --if-present _syncPnpm",
     "build:docs": "mkdir -p packages/-ember-data/dist && cd ./docs-generator && node ./compile-docs.js",
     "lint": "bun run turbo --log-order=stream lint --concurrency=1",
     "lint:prettier": "prettier --check --cache --cache-location=.prettier-cache --log-level=warn .",

packages/active-record/package.json

@@ -61,7 +61,8 @@
     "README.md",
     "LICENSE.md",
     "ember-data-logo-dark.svg",
-    "ember-data-logo-light.svg"
+    "ember-data-logo-light.svg",
+    "unstable-preview-types"
   ],
   "exports": {
     "./*": {

packages/unpublished-test-infra/package.json

@@ -13,13 +13,36 @@
   },
   "license": "MIT",
   "author": "",
+  "files": [
+    "addon-test-support",
+    "src",
+    "index.js",
+    "dist",
+    "tsconfig.json"
+  ],
+  "typesVersions": {
+    "*": {
+      "test-support": [
+        "dist/addon-test-support/index.d.ts"
+      ],
+      "test-support/*": [
+        "dist/addon-test-support/*",
+        "dist/addon-test-support/*/index.d.ts"
+      ],
+      "*": [
+        "dist/addon/*",
+        "dist/addon/*/index.d.ts"
+      ]
+    }
+  },
   "directories": {
     "doc": "doc",
     "test": "tests"
   },
   "scripts": {
-    "check:types": "tsc --noEmit",
     "test:infra": "ember test",
+    "build:types": "tsc --build --emitDeclarationOnly",
+    "_build": "bun run build:types",
     "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
   "peerDependencies": {

packages/unpublished-test-infra/tsconfig.json

@@ -13,7 +13,7 @@
     "allowSyntheticDefaultImports": true,
     "forceConsistentCasingInFileNames": true,
     "allowJs": true,
-    "noEmit": true,
+    "noEmit": false,
     "noImplicitOverride": true,
 
     // Enable faster builds

tests/builders/app/app.ts

@@ -8,7 +8,7 @@ import Resolver from './resolver';
 class App extends Application {
   modulePrefix = config.modulePrefix;
   podModulePrefix = config.podModulePrefix;
-  Resolver = Resolver;
+  override Resolver = Resolver;
 }
 
 loadInitializers(App, config.modulePrefix);

tests/builders/app/services/store.ts

@@ -7,8 +7,9 @@ import { buildSchema, modelFor } from '@ember-data/model/hooks';
 import RequestManager from '@ember-data/request';
 import Fetch from '@ember-data/request/fetch';
 import DataStore, { CacheHandler } from '@ember-data/store';
-import type { Cache } from '@ember-data/store/-types/cache/cache';
 import type { CacheCapabilitiesManager } from '@ember-data/store/-types/q/cache-store-wrapper';
+import { ModelSchema } from '@ember-data/store/-types/q/ds-model';
+import type { Cache } from '@warp-drive/core-types/cache';
 
 export default class Store extends DataStore {
   constructor(args: unknown) {
@@ -21,19 +22,22 @@ export default class Store extends DataStore {
     this.registerSchema(buildSchema(this));
   }
 
-  createCache(capabilities: CacheCapabilitiesManager): Cache {
+  override createCache(capabilities: CacheCapabilitiesManager): Cache {
     return new JSONAPICache(capabilities);
   }
 
-  instantiateRecord(identifier: StableRecordIdentifier, createRecordArgs: { [key: string]: unknown }): unknown {
+  override instantiateRecord(
+    identifier: StableRecordIdentifier,
+    createRecordArgs: { [key: string]: unknown }
+  ): unknown {
     return instantiateRecord.call(this, identifier, createRecordArgs);
   }
 
-  teardownRecord(record: Model): void {
+  override teardownRecord(record: Model): void {
     return teardownRecord.call(this, record);
   }
 
-  modelFor(type: string) {
-    return modelFor.call(this, type);
+  override modelFor(type: string): ModelSchema {
+    return modelFor.call(this, type)!;
   }
 }

tests/builders/package.json

@@ -16,6 +16,7 @@
   "scripts": {
     "build:tests": "IS_TESTING=true EMBER_CLI_TEST_COMMAND=true ember build --output-path=dist-test --suppress-sizes",
     "build:production": "pnpm build:tests -e production",
+    "check:types": "tsc --noEmit",
     "test": "bun ./diagnostic.js",
     "test:production": "bun ./diagnostic.js",
     "_syncPnpm": "bun run sync-dependencies-meta-injected"
@@ -114,6 +115,7 @@
     "ember-source-channel-url": "^3.0.0",
     "loader.js": "^4.7.0",
     "silent-error": "^1.1.1",
+    "typescript": "^5.2.2",
     "webpack": "^5.89.0"
   },
   "ember": {

tests/builders/tests/integration/create-record-test.ts

@@ -6,16 +6,18 @@ import JSONAPICache from '@ember-data/json-api';
 import { createRecord } from '@ember-data/json-api/request';
 import Model, { attr, instantiateRecord, teardownRecord } from '@ember-data/model';
 import { buildSchema, modelFor } from '@ember-data/model/hooks';
-import type { StructuredDataDocument } from '@ember-data/request';
+import type { RequestContext, StructuredDataDocument } from '@ember-data/request';
 import RequestManager from '@ember-data/request';
-import type { Future, Handler, RequestContext } from '@ember-data/request/-private/types';
 import { setBuildURLConfig } from '@ember-data/request-utils';
+import type { Future, Handler } from '@ember-data/request/-private/types';
 import DataStore, { CacheHandler, recordIdentifierFor } from '@ember-data/store';
-import type { Cache } from '@ember-data/store/-types/cache/cache';
-import { SingleResourceDataDocument } from '@ember-data/store/-types/cache/document';
 import type { CacheCapabilitiesManager } from '@ember-data/store/-types/q/cache-store-wrapper';
-import { SingleResourceDocument } from '@warp-drive/core-types/spec/raw';
+import { ModelSchema } from '@ember-data/store/-types/q/ds-model';
 import { JsonApiError } from '@ember-data/store/-types/q/record-data-json-api';
+import { TestContext } from '@ember/test-helpers';
+import type { Cache } from '@warp-drive/core-types/cache';
+import type { SingleResourceDataDocument } from '@warp-drive/core-types/spec/document';
+import type { SingleResourceDocument } from '@warp-drive/core-types/spec/raw';
 
 class TestStore extends DataStore {
   constructor(args: unknown) {
@@ -27,20 +29,23 @@ class TestStore extends DataStore {
     this.registerSchema(buildSchema(this));
   }
 
-  createCache(capabilities: CacheCapabilitiesManager): Cache {
+  override createCache(capabilities: CacheCapabilitiesManager): Cache {
     return new JSONAPICache(capabilities);
   }
 
-  instantiateRecord(identifier: StableRecordIdentifier, createRecordArgs: { [key: string]: unknown }): unknown {
+  override instantiateRecord(
+    identifier: StableRecordIdentifier,
+    createRecordArgs: { [key: string]: unknown }
+  ): unknown {
     return instantiateRecord.call(this, identifier, createRecordArgs);
   }
 
-  teardownRecord(record: Model): void {
+  override teardownRecord(record: Model): void {
     return teardownRecord.call(this, record);
   }
 
-  modelFor(type: string) {
-    return modelFor.call(this, type);
+  override modelFor(type: string): ModelSchema {
+    return modelFor.call(this, type)!;
   }
 }
 
@@ -59,23 +64,23 @@ module('Integration - createRecord', function (hooks) {
     setBuildURLConfig({ host: '', namespace: '' });
   });
 
-  test('Saving a new record with a createRecord op works as expected', async function (assert) {
+  test('Saving a new record with a createRecord op works as expected', async function (this: TestContext, assert) {
     const { owner } = this;
 
     // intercept cache APIs to ensure they are called as expected
     class TestCache extends JSONAPICache {
-      willCommit(identifier: StableRecordIdentifier): void {
+      override willCommit(identifier: StableRecordIdentifier): void {
         assert.step(`willCommit ${identifier.lid}`);
         return super.willCommit(identifier);
       }
-      didCommit(
+      override didCommit(
         committedIdentifier: StableRecordIdentifier,
         result: StructuredDataDocument<SingleResourceDocument>
       ): SingleResourceDataDocument<StableExistingRecordIdentifier> {
         assert.step(`didCommit ${committedIdentifier.lid}`);
         return super.didCommit(committedIdentifier, result);
       }
-      commitWasRejected(identifier: StableRecordIdentifier, errors?: JsonApiError[]): void {
+      override commitWasRejected(identifier: StableRecordIdentifier, errors?: JsonApiError[]): void {
         assert.step(`commitWasRejected ${identifier.lid}`);
         return super.commitWasRejected(identifier, errors);
       }
@@ -101,7 +106,7 @@ module('Integration - createRecord', function (hooks) {
         const manager = this.requestManager;
         manager.use([TestHandler]);
       }
-      createCache(capabilities: CacheCapabilitiesManager): Cache {
+      override createCache(capabilities: CacheCapabilitiesManager): Cache {
         return new TestCache(capabilities);
       }
     }
@@ -139,23 +144,23 @@ module('Integration - createRecord', function (hooks) {
     assert.verifySteps([`willCommit ${identifier.lid}`, 'handle createRecord request', `didCommit ${identifier.lid}`]);
   });
 
-  test('Rejecting during Save of a new record with a createRecord op works as expected', async function (assert) {
+  test('Rejecting during Save of a new record with a createRecord op works as expected', async function (this: TestContext, assert) {
     const { owner } = this;
 
     // intercept cache APIs to ensure they are called as expected
     class TestCache extends JSONAPICache {
-      willCommit(identifier: StableRecordIdentifier): void {
+      override willCommit(identifier: StableRecordIdentifier): void {
         assert.step(`willCommit ${identifier.lid}`);
         return super.willCommit(identifier);
       }
-      didCommit(
+      override didCommit(
         committedIdentifier: StableRecordIdentifier,
         result: StructuredDataDocument<SingleResourceDocument>
       ): SingleResourceDataDocument<StableExistingRecordIdentifier> {
         assert.step(`didCommit ${committedIdentifier.lid}`);
         return super.didCommit(committedIdentifier, result);
       }
-      commitWasRejected(identifier: StableRecordIdentifier, errors?: JsonApiError[]): void {
+      override commitWasRejected(identifier: StableRecordIdentifier, errors?: JsonApiError[]): void {
         assert.step(`commitWasRejected ${identifier.lid}`);
         return super.commitWasRejected(identifier, errors);
       }
@@ -181,7 +186,7 @@ module('Integration - createRecord', function (hooks) {
         const manager = this.requestManager;
         manager.use([TestHandler]);
       }
-      createCache(capabilities: CacheCapabilitiesManager): Cache {
+      override createCache(capabilities: CacheCapabilitiesManager): Cache {
         return new TestCache(capabilities);
       }
     }