Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: findRecord should not cache if includes differ #7687

Closed
wants to merge 1 commit into from
Closed

Failing test: findRecord should not cache if includes differ #7687

wants to merge 1 commit into from

Conversation

kpfefferle
Copy link
Contributor

@kpfefferle kpfefferle commented Aug 30, 2021 •
edited
Loading

In 3.28, it seems that #7651 made a change to always return an existing inflight findRecord for a given model - even if the request itself would have been different (such as by using different include options).

This PR adds a test asserting that the findRecord caching (asserted by the previous test) should not apply if the include arguments differ.

@kpfefferle kpfefferle mentioned this pull request Aug 30, 2021
Closed
@kpfefferle
Copy link
Contributor Author

cc: @igorT

@igorT
Copy link
Member

igorT commented Sep 3, 2021

Thanks for the test case, on it

@snewcomer snewcomer mentioned this pull request Sep 11, 2021
Merged
@kpfefferle
Copy link
Contributor Author

Addressed by #7702

@kpfefferle kpfefferle closed this Dec 13, 2021
@kpfefferle kpfefferle deleted the multiple-findrecord-includes branch December 13, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpfefferle @igorT