fix: add asserts and assert tests for belongsTo/hasMany/findRecord empty responses #7550

runspired · 2021-05-26T07:25:22Z

resolves #7547
resolves #6920

In the case of belongsTo/hasMany this would already have thrown an error but it would have been a confusing one. You will still get a somewhat more confusing one if the response contains only links but not meta as it will fail validateDocumentStructure as JSON:API insists that documents have at-least one-of data/errors/meta

…esponses

github-actions · 2021-05-26T07:39:01Z

Asset Size Report for fccad2e

IE11 Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (IE11)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '198.17 KB' │
│ compressed │ '40.56 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '81.95 KB' │
│  compressed  │ '16.77 KB' │
│ % Of Library │   '41.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 81.03 KB  | 16.58 KB   | 98.9          | 40.9
	@ember-data/store/index                           | 936.00 B  | 191.54 B   | 1.1           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.18 KB' │
│  compressed  │ '6.59 KB'  │
│ % Of Library │   '16.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 31.70 KB  | 6.49 KB    | 98.5          | 16.0
	@ember-data/model/index                           | 486.00 B  | 99.45 B    | 1.5           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.71 KB' │
│  compressed  │ '5.26 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.71 KB  | 5.26 KB    | 100.0         | 13.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.13 KB' │
│  compressed  │ '4.32 KB'  │
│ % Of Library │   '10.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.84 KB   | 1.60 KB    | 37.1          | 4.0
	@ember-data/serializer/-private                   | 5.81 KB   | 1.19 KB    | 27.5          | 2.9
	@ember-data/serializer/json-api                   | 3.96 KB   | 829.42 B   | 18.7          | 2.0
	@ember-data/serializer/rest                       | 3.04 KB   | 638.08 B   | 14.4          | 1.5
	@ember-data/serializer/index                      | 273.00 B  | 55.86 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 43.99 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.53 KB' │
│  compressed  │ '3.59 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.79 KB   | 1.80 KB    | 50.1          | 4.4
	@ember-data/adapter/-private                      | 3.91 KB   | 819.40 B   | 22.3          | 2.0
	@ember-data/adapter/error                         | 1.98 KB   | 414.20 B   | 11.3          | 1.0
	@ember-data/adapter/index                         | 1.51 KB   | 316.58 B   | 8.6           | 0.8
	@ember-data/adapter/json-api                      | 1.35 KB   | 282.00 B   | 7.7           | 0.7

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.54 KB' │
│  compressed  │ '1.95 KB' │
│ % Of Library │   '4.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 506.29 B   | 25.3          | 1.2
	ember-data/-private                               | 2.18 KB   | 455.95 B   | 22.8          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 249.05 B   | 12.5          | 0.6
	ember-data/setup-container                        | 520.00 B  | 106.41 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 65.07 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 56.07 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 51.36 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 50.13 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.72 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.72 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 49.31 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.50 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.47 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 46.24 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 45.43 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.43 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.61 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 33.15 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.07 KB' │
│  compressed  │ '1.45 KB' │
│ % Of Library │   '3.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 651.59 B   | 44.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 332.95 B   | 22.5          | 0.8
	ember-inflector/lib/helpers/pluralize             | 506.00 B  | 103.55 B   | 7.0           | 0.2
	ember-inflector/index                             | 473.00 B  | 96.79 B    | 6.5           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 96.38 B    | 6.5           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 72.03 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 332.00 B  | 67.94 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 60.57 B    | 4.1           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '3.07 KB'  │
│  compressed  │ '642.99 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.58 KB   | 540.66 B   | 84.1          | 1.3
	@ember-data/debug/setup                           | 500.00 B  | 102.32 B   | 15.9          | 0.2

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '179.35 KB' │
│ compressed │ '38.93 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.43 KB' │
│  compressed  │ '15.72 KB' │
│ % Of Library │   '40.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.51 KB  | 15.52 KB   | 98.7          | 39.9
	@ember-data/store/index                           | 936.00 B  | 203.18 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.63 KB' │
│  compressed  │ '6.21 KB'  │
│ % Of Library │   '16.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.16 KB  | 6.11 KB    | 98.3          | 15.7
	@ember-data/model/index                           | 486.00 B  | 105.49 B   | 1.7           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.73 KB' │
│  compressed  │ '5.15 KB'  │
│ % Of Library │   '13.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.73 KB  | 5.15 KB    | 100.0         | 13.2

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.65 KB' │
│  compressed  │ '4.27 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.21 KB   | 1.57 KB    | 36.7          | 4.0
	@ember-data/serializer/-private                   | 5.49 KB   | 1.19 KB    | 27.9          | 3.1
	@ember-data/serializer/json-api                   | 3.73 KB   | 828.36 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.76 KB   | 613.89 B   | 14.1          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 56.00 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.67 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.85 KB' │
│  compressed  │ '3.44 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.10 KB   | 1.76 KB    | 51.1          | 4.5
	@ember-data/adapter/-private                      | 3.69 KB   | 820.11 B   | 23.3          | 2.1
	@ember-data/adapter/error                         | 1.94 KB   | 431.76 B   | 12.3          | 1.1
	@ember-data/adapter/index                         | 1.10 KB   | 244.21 B   | 6.9           | 0.6
	@ember-data/adapter/json-api                      | 1.02 KB   | 226.40 B   | 6.4           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.54 KB' │
│  compressed  │ '2.07 KB' │
│ % Of Library │   '5.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 537.04 B   | 25.3          | 1.3
	ember-data/-private                               | 2.18 KB   | 483.64 B   | 22.8          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 264.18 B   | 12.5          | 0.7
	ember-data/setup-container                        | 520.00 B  | 112.87 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 69.03 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.47 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 54.48 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.18 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.74 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.74 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 52.31 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.44 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.36 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.05 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 48.19 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.19 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.32 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 35.16 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.45 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 640.15 B   | 43.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 353.18 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 102.67 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.24 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 80.96 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 76.41 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.02 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.25 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '624.31 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 515.98 B   | 82.6          | 1.3
	@ember-data/debug/setup                           | 499.00 B  | 108.32 B   | 17.4          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '219.02 KB' │
│ compressed │ '42.22 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '96.61 KB' │
│  compressed  │ '18.62 KB' │
│ % Of Library │   '44.1'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.18 KB  | 3.31 KB    | 17.8          | 7.8
	@ember-data/store/-private/system/model/internal-model                             | 14.45 KB  | 2.79 KB    | 15.0          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.05 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.03 KB   | 992.06 B   | 5.2           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.57 KB   | 902.99 B   | 4.7           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 4.19 KB   | 826.46 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.91 KB   | 772.48 B   | 4.1           | 1.8
	@ember-data/store/-private/index                                                   | 3.57 KB   | 704.62 B   | 3.7           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.36 KB   | 662.98 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.26 KB   | 643.51 B   | 3.4           | 1.5
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.95 KB   | 581.82 B   | 3.1           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 450.34 B   | 2.4           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.96 KB   | 387.10 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 372.26 B   | 2.0           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 302.47 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.51 KB   | 298.62 B   | 1.6           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 261.02 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 260.06 B   | 1.4           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 225.17 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 207.82 B   | 1.1           | 0.5
	@ember-data/store/-private/system/references/record                                | 982.00 B  | 189.31 B   | 1.0           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 967.00 B  | 186.42 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 180.44 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 934.00 B  | 180.06 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 170.80 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 798.00 B  | 153.84 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 145.16 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 134.37 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 607.00 B  | 117.01 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 115.28 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 101.59 B   | 0.5           | 0.2
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 97.54 B    | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 95.62 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.88 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.75 B    | 0.5           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 77.11 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.76 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 390.00 B  | 75.18 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 63.04 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.91 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.90 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 269.00 B  | 51.85 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.54 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.41 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.87 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.48 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.89 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.50 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 95.00 B   | 18.31 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 95.00 B   | 18.31 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 18.31 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.35 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 17.15 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 89.00 B   | 17.15 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.38 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.38 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.61 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 15.03 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.45 B    | 0.1           | 0.0

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.58 KB' │
│  compressed  │ '6.28 KB'  │
│ % Of Library │   '14.9'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.89 KB   | 1.91 KB    | 30.4          | 4.5
	@ember-data/model/-private/record-state                               | 6.17 KB   | 1.19 KB    | 18.9          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.80 KB   | 750.89 B   | 11.7          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.85 KB   | 562.54 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.08 KB   | 411.40 B   | 6.4           | 1.0
	@ember-data/model/-private/index                                      | 1.42 KB   | 280.69 B   | 4.4           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.25 KB   | 247.34 B   | 3.8           | 0.6
	@ember-data/model/-private/attr                                       | 857.00 B  | 165.21 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 162.90 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 660.00 B  | 127.23 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 621.00 B  | 119.71 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.69 B    | 1.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 86.17 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 85.21 B    | 1.3           | 0.2
	@ember-data/model/-private/system/diff-array                          | 438.00 B  | 84.43 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 431.00 B  | 83.08 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.67 KB' │
│  compressed  │ '5.91 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.22 KB   | 1.58 KB    | 26.8          | 3.8
	@ember-data/record-data/-private/graph/index                                      | 4.86 KB   | 959.29 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.14 KB   | 619.80 B   | 10.2          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.83 KB   | 557.72 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.01 KB   | 396.74 B   | 6.6           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.92 KB   | 379.59 B   | 6.3           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.50 KB   | 296.69 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.05 KB   | 207.24 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1022.00 B | 197.02 B   | 3.3           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 188.34 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 788.00 B  | 151.91 B   | 2.5           | 0.4
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 133.40 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 667.00 B  | 128.58 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 78.27 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.48 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.88 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 100.00 B  | 19.27 B    | 0.3           | 0.0
	@ember-data/record-data/-private/graph/-operations                                | 79.00 B   | 15.22 B    | 0.3           | 0.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.08 KB' │
│  compressed  │ '4.26 KB'  │
│ % Of Library │   '10.1'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.21 KB   | 1.39 KB    | 32.7          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.39 KB   | 866.17 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.73 KB   | 735.66 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.76 KB   | 545.19 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 233.26 B   | 5.4           | 0.5
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.82 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 507.00 B  | 97.74 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.98 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 368.00 B  | 70.94 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 58.41 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.73 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 257.00 B  | 49.54 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.44 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.92 KB' │
│  compressed  │ '3.46 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.10 KB   | 1.56 KB    | 45.2          | 3.7
	@ember-data/adapter/error                                     | 1.94 KB   | 383.44 B   | 10.8          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.86 KB   | 367.63 B   | 10.4          | 0.9
	@ember-data/adapter/index                                     | 1.10 KB   | 216.88 B   | 6.1           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 203.57 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.02 KB   | 201.07 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 152.68 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 566.00 B  | 109.11 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.53 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.52 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.89 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.79 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 76.00 B   | 14.65 B    | 0.4           | 0.0

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.65 KB' │
│  compressed  │ '1.86 KB' │
│ % Of Library │   '4.4'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 476.94 B   | 25.0          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 380.55 B   | 20.0          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 234.61 B   | 12.3          | 0.5
	ember-data/setup-container                        | 520.00 B  | 100.24 B   | 5.3           | 0.2
	ember-data/-private/core                          | 366.00 B  | 70.55 B    | 3.7           | 0.2
	ember-data/relationships                          | 318.00 B  | 61.30 B    | 3.2           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.82 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.38 B    | 2.5           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.23 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.84 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.84 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.46 B    | 2.4           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.68 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.72 B    | 2.3           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.56 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.79 B    | 2.2           | 0.1
	ember-data/store                                  | 222.00 B  | 42.79 B    | 2.2           | 0.1
	ember-data/attr                                   | 218.00 B  | 42.02 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 31.23 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.29 KB' │
│ % Of Library │   '3.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 568.51 B   | 43.0          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 313.65 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 91.18 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.80 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.90 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.85 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.30 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 57.06 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '554.44 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 458.24 B   | 82.6          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 96.19 B    | 17.4          | 0.2

github-actions · 2021-05-26T08:02:31Z

Performance Report for fccad2e

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 36ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-12ms to 13ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-6ms to 25ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-8ms to 7ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-2ms to 5ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-25ms to 32ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-14ms to 10ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-16ms to 21ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-5ms to 10ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-2ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-32ms to 42ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-17ms to 10ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-17ms to 27ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-13ms to 15ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-2ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-6ms to 35ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-4ms to 21ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-6ms to 14ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-3ms to 5ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 3ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-15ms to 49ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-15ms to 13ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-3ms to 39ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-3ms to 2ms]

snewcomer

Nice debug assertions!

runspired added 2 commits May 25, 2021 23:33

stub test

a70584b

add asserts and assert tests for belongsTo/hasMany/findRecord empty r…

fccad2e

…esponses

runspired added the 🏷️ bug This PR primarily fixes a reported issue label May 26, 2021

snewcomer approved these changes May 26, 2021

View reviewed changes

runspired merged commit bb6b64b into master May 26, 2021

delete-merged-branch bot deleted the runspired/better-asserts branch May 26, 2021 17:02

ijlee2 mentioned this pull request Aug 31, 2021

Ember 3.28 release ember-learn/ember-blog#1029

Merged

40 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add asserts and assert tests for belongsTo/hasMany/findRecord empty responses #7550

fix: add asserts and assert tests for belongsTo/hasMany/findRecord empty responses #7550

runspired commented May 26, 2021 •

edited

Loading

github-actions bot commented May 26, 2021

github-actions bot commented May 26, 2021

snewcomer left a comment

fix: add asserts and assert tests for belongsTo/hasMany/findRecord empty responses #7550

fix: add asserts and assert tests for belongsTo/hasMany/findRecord empty responses #7550

Conversation

runspired commented May 26, 2021 • edited Loading

github-actions bot commented May 26, 2021

github-actions bot commented May 26, 2021

snewcomer left a comment

Choose a reason for hiding this comment

runspired commented May 26, 2021 •

edited

Loading